Repository navigation
docs: clarify configurable concurrency in overview - #24207
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
246700a8-6cab-478d-ad3f-2485dfbcf594
📒 Files selected for processing (1)
overview.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
🟡 Changes recommended
The wording still risks presenting token-limit as a session cap rather than a concurrent request-execution limit.
2 open findings
What changed in this PR
Clarifies how TiDB’s token-limit controls concurrent request execution.
Changes:
- Documents the default and maximum token limits.
- Clarifies token acquisition during SQL processing.
| File | Description |
|---|---|
overview.md |
Updates concurrency limits in the overview. |
performance-tuning-methods.md |
Clarifies when requests wait for tokens. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated wording for clarity on session limits in TiDB. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Synced from: pingcap/docs#24207 Target PR: pingcap#21977 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |

What is changed, added, or deleted? (Required)
Clarify the concurrency wording in
overview.md.The overview previously said that each TiDB node supports a maximum of
1,000concurrencies. However,1,000is the default value oftoken-limit, not the maximum. This PR updates the overview to say that each TiDB node supports1,000concurrent sessions by default and that you can configure this limit up to1,048,576.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
token-limit. The 512-node computing-layer maximum and PB-level cluster-capacity statement remain unchanged.get tokendescription to specify that token limiting applies when sessions concurrently executing requests on a TiDB instance reachtoken-limit, and linked to the relevant configuration details.