Skip to content

docs: clarify configurable concurrency in overview - #21977

Open
lilin90 wants to merge 3 commits into
pingcap:masterfrom
lilin90:docs/fix-overview-token-limit-24207
Open

lilin90 wants to merge 3 commits into
pingcap:masterfrom
lilin90:docs/fix-overview-token-limit-24207

Conversation

@lilin90

@lilin90 lilin90 commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

What is changed, added, or deleted? (Required)

Clarify the concurrency wording in overview.md.

The overview previously said that each TiDB node supports a maximum of 1,000 concurrencies. However, 1,000 is the default value of token-limit, not the maximum. This PR updates the overview to say that each TiDB node supports 1,000 concurrent sessions by default and that you can configure this limit up to 1,048,576.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • 文档
    • 明确默认每个 TiDB 节点最多允许 1,000 个会话并发执行请求;可通过 token-limit 将上限调至最高 1,048,576。计算节点上限仍为 512,集群容量仍为 PB 级别。
    • 更新令牌等待条件:单个 TiDB 实例上的并发会话数达到 token-limit 时,后续请求需等待。

Copilot AI balanced review requested due to automatic review settings October 13, 2026 09:45
@lilin90 lilin90 added area/general Relates to TiDB overview, architecture, and other general descriptions. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug. labels Oct 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2026
@lilin90 lilin90 self-assigned this Oct 13, 2026
Synced from: pingcap/docs#24207
Target PR: pingcap#21977

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Auto-sync completed successfully

Source PR: pingcap/docs#24207
Target PR: #21977

Chinese documentation has been updated based on English documentation changes.

@ti-chi-bot

ti-chi-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs-cn/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e54f8cc7-590e-43ad-8d19-c2e148bd775f
📥 Commits

Reviewing files that changed from the base of the PR and between ff17d70 and 6966107.

📒 Files selected for processing: 1
  • overview.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

更新 OLTP 场景中的 TiDB 并发限制说明,并调整 get token 阶段的等待条件及配置链接。

Changes: 并发限制文档

Layer / File(s) Summary
并发限制与 token 说明
overview.md, performance-tuning-methods.md
overview.md 说明每个 TiDB 节点默认允许 1,000 个会话并发执行请求,并可通过 token-limit 调高至 1,048,576。performance-tuning-methods.md 将等待条件改为单个 TiDB 实例的并发会话数达到 token-limit,并更新配置项链接。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to 69661

The updated guidance matches the documented token limit and waiting behavior; no actionable issue remains, and the documentation change is ready to merge.

### Architecture Summary

Architecture risk: 🔵 Low · up to 69661

The change affects 2 systems.

Changed systems: overview.md, performance-tuning-methods.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — overview.md (service) was modified; 1 changed file maps to changed impact.
  • observed — performance-tuning-methods.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in performance-tuning-methods.md: get token 阶段的等待条件改为单个 TiDB 实例上的并发会话数达到 token-limit 后,后续请求等待可用 token;旧文案描述连接数触及限制时创建连接被限流,且链接未指向具体配置项锚点。
  • observed — Modified behavior in overview.md: OLTP 场景说明将“每个节点最大支持 1000 并发”改为默认每个 TiDB 节点最多允许 1,000 个会话并发执行请求,并说明可通过 token-limit 将限制最高调至 1,048,576。
Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Title check Passed 标题简洁明确,准确概括了主要变更:澄清 overview.md 中可配置的并发限制。
Description check Passed 描述已填写变更内容、适用版本、相关链接、AI agent 参与情况和变更类型检查项。内容与实际改动一致。首次贡献者清单可按模板说明省略。
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The overview should explicitly identify 1,048,576 as the configurable upper limit.

1 open finding

🧠 Review effort: Balanced

Comment thread overview.md Outdated
@lilin90
lilin90 requested a review from GMHDBJD October 14, 2026 02:10
Updated the description of TiDB's capabilities in handling large data and high concurrency scenarios.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 20, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-20 09:03:50.987881585 +0000 UTC m=+94643.247968513: ☑️ agreed by GMHDBJD.

@lilin90 lilin90 added the lgtm label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/general Relates to TiDB overview, architecture, and other general descriptions. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants