dev/v3.0/v2.1: add a tip for binlogctl's usage #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Please help review this PR, Thanks a lot! @TomShawn |
TomShawn
reviewed
Aug 5, 2019
v3.0/how-to/maintain/tidb-binlog.md
Outdated
| @@ -100,7 +100,7 @@ Command example: | |||
| bin/binlogctl -pd-urls=http://127.0.0.1:2379 -cmd update-pump -node-id ip-127-0-0-1:8250 -state paused | |||
| ``` | |||
|
|
|||
| This command modifies the state of Pump or Drainer saved in the Placement Driver (PD). | |||
| This command modifies the state of Pump or Drainer saved in the Placement Driver (PD) and is only used if Pump or Drainer service fails to function properly. | |||
There was a problem hiding this comment.
From the context, the reader must use this command very carefully. This information would be better understood if it is in the note format and active voice is used.
Suggested change
| This command modifies the state of Pump or Drainer saved in the Placement Driver (PD) and is only used if Pump or Drainer service fails to function properly. | |
| > **Note:** | |
| > | |
| > This command modifies the state of Pump or Drainer saved in the Placement Driver (PD). | |
| > Use this command **only** when the Pump or Drainer service fails to function properly. |
TomShawn
suggested changes
Aug 5, 2019
|
PTAL :) @TomShawn |
5 tasks
yikeke
added
the
translation/from-docs-cn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
What is the related PR or file link(s)?
pingcap/docs-cn#1663
Which version does your change affect?
dev, v3.0, v2.1
Checklist
TOC.mdtitlein metadataTOC.md