Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add binlogctl tip for v2.1 and v3 #1714

Merged
merged 1 commit into from
Aug 7, 2019
Merged

tools: add binlogctl tip for v2.1 and v3 #1714

merged 1 commit into from
Aug 7, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Aug 5, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

add a tip for binlogctl for v2.1 and v3

What is the related PR or file link(s)?

#1663
pingcap/docs#1415

Which version does your change affect?

dev, v3.0 and v2.1

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@WangXiangUSTC WangXiangUSTC requested review from lilin90 and removed request for lilin90 August 5, 2019 09:47
suzaku
suzaku reviewed Aug 6, 2019
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilin90
lilin90 approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit ab234ba into pingcap:master Aug 7, 2019
@lilin90 lilin90 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 7, 2019
@WangXiangUSTC WangXiangUSTC mentioned this pull request Aug 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @suzaku @lilin90