Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: rename products #13692

Merged
merged 19 commits into from
Jun 2, 2023
Merged
Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented May 26, 2023

What is changed, added or deleted? (Required)

  • Remove the use of "on-premises" and similar ones
  • Update "TiDB Cloud Serverless Tier" and similar ones to "TiDB Serverless"
  • Update affected anchor links

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch
Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2023
@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label May 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 26, 2023
@qiancai qiancai added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 26, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2023
@qiancai qiancai removed the missing-translation-status This PR does not have translation status info. label May 29, 2023
@qiancai qiancai requested a review from ran-huang May 29, 2023 03:56
releases/release-6.0.0-dmr.md Outdated Show resolved Hide resolved
@@ -248,7 +248,7 @@ In v7.0.0-DMR, the key new features and improvements are as follows:
* [DBeaver](https://dbeaver.io/) v23.0.1 supports TiDB by default [#17396](https://github.com/dbeaver/dbeaver/issues/17396) @[Icemap](https://github.com/Icemap)

- Provides an independent TiDB module, icon, and logo.
- The default configuration supports [TiDB Cloud Serverless Tier](https://docs.pingcap.com/tidbcloud/select-cluster-tier#serverless-tier-beta), making it easier to connect to Serverless Tier.
- The default configuration supports [TiDB Serverless](https://docs.pingcap.com/tidbcloud/select-cluster-tier#serverless-tier-beta), making it easier to connect to TiDB Serverless.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud 没有改 release notes,TiDB 的要改吗?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为每个版本的 TiDB 的用户文档里 Serverless Tier 都会修改,比如 v7.0.0 的用户文档里的 Serverless Tier 都会替换,没有改 v7.0.0 release notes 可能导致 v7.0.0 自己不太一致。

这个和 TiDB Cloud 的 release notes 的情况不太一样,因为 Cloud 用户一般只会去看 Cloud 最新的 release notes,不会看之前版本的。但是对于 TiDB,各个版本的用户看 release notes 的版本也不一样

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 1, 2023

@qiancai @ran-huang 17bbb93 PTAL

@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 2, 2023
@qiancai qiancai removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jun 2, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Jun 2, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 892dd5a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 76416ca into pingcap:master Jun 2, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13763.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2023
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2023
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13764.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2023
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #13765.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 2, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2023
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13766.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 2, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 2, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 2, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

4 participants