Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud: rename three products #13668

Merged
merged 21 commits into from
Jun 2, 2023
Merged

cloud: rename three products #13668

merged 21 commits into from
Jun 2, 2023

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented May 24, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

rename three products:

  • TiDB Serverless
  • TiDB Dedicated
  • TiDB Self-Hosted

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
cloud: rename three products
3d8ac68 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 24, 2023
@ran-huang ran-huang added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 24, 2023
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2023
ran-huang added 3 commits May 24, 2023 17:29
@ran-huang
fix anchor
2e9d661 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
update wording in release notes
8e45a12
@ran-huang
update on-premises
04896bd 
Signed-off-by: Ran <huangran.alex@gmail.com>
ran-huang
ran-huang commented May 25, 2023
View reviewed changes
tidb-cloud/select-cluster-tier.md Outdated
@@ -1,27 +1,27 @@
---
title: Select Your Cluster Tier
summary: Learn how to select your cluster tier on TiDB Cloud.
title: Select Your Cluster Option
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这个表述有点奇怪

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a Database Type 可以吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Database Type -> Cluster Type，这样呢

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

的确，是集群类型。 界面的 Tier 如果不改的话，感觉这里也不用改

@ran-huang ran-huang marked this pull request as ready for review May 25, 2023 07:15
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2023
@ran-huang ran-huang requested a review from qiancai May 25, 2023 07:15
@ran-huang
revert release notes
c320054 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang force-pushed the cloud/rename-3-products branch from e6f8fba to c320054 Compare May 26, 2023 02:58
qiancai
qiancai reviewed May 26, 2023
View reviewed changes
tidb-cloud/select-cluster-tier.md Outdated
@@ -1,27 +1,27 @@
---
title: Select Your Cluster Tier
summary: Learn how to select your cluster tier on TiDB Cloud.
title: Select Your Cluster Option
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a Database Type 可以吗

tidb-cloud/tidb-cloud-glossary.md Outdated

### cluster tier
### cluster option
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是否算一个术语

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉不算，可以删了吧

@ran-huang @qiancai
Apply suggestions from code review
549774a 
Co-authored-by: Grace Cai <qqzczy@126.com>
This was referenced May 29, 2023
Merged
Merged
qiancai added 2 commits May 30, 2023 11:08
@qiancai
update the usage of on-premises
956f295
@qiancai
TiDB Cloud Serverless Tier -> TiDB Serverless; TiDB Cloud (Serverless…
747b1cd 
… Tier) -> TiDB Serverless; TiDB Cloud [Serverless Tier] -> [TiDB Serverless]
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
qiancai
qiancai approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2023
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f8ea64b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit cc92c60 into pingcap:release-6.5 Jun 2, 2023
@ran-huang ran-huang deleted the cloud/rename-3-products branch June 2, 2023 03:53
This was referenced Jun 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@lilin90 lilin90 mentioned this pull request Jun 8, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
area/tidb-cloud This PR relates to the area of TiDB Cloud. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ran-huang @qiancai