Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/sql/statements: First Batch of Statement Reference #1067

Merged
merged 6 commits into from
May 8, 2019
Merged

reference/sql/statements: First Batch of Statement Reference #1067

merged 6 commits into from
May 8, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Apr 19, 2019

This replaces the previous statement reference, which had titles like "Data Definition Statements", "Data Manipulation Statements". The reference benefits by being structured how a user will Google search. i.e. If I need help with the CREATE INDEX statement because I am getting an error. I will Google "CREATE INDEX TiDB syntax" etc.

It does not include all of the statements that TiDB supports. In an effort to reduce reviewer burden, and ship something I have not included the following:

  • ADMIN statements
  • BINDING statements
  • Binlog/pumper/drainer etc statements
  • Role statements
  • Stats statements
  • Plugin statements
  • Lock tables statements

For reviewers: there is a lot here. I appreciate if you see something obvious, please feel free to commit to my branch directly. I will watch the commits and take responsibility if any edits look like they are in error.

@morgo morgo marked this pull request as ready for review April 20, 2019 14:41
@morgo morgo requested review from kolbe and lilin90 April 20, 2019 14:44
@lilin90 lilin90 requested a review from zz-jason April 22, 2019 12:23
@ceohockey60 ceohockey60 self-assigned this Apr 22, 2019
@ceohockey60 ceohockey60 self-requested a review April 22, 2019 17:33
@ceohockey60 ceohockey60 removed their assignment Apr 22, 2019
Copy link
Contributor

@ceohockey60 ceohockey60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link

winkyao commented May 8, 2019

@bb7133 @zimulala PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented May 8, 2019

Thank you for your efforts @morgo

@bb7133 bb7133 merged commit 9daadf7 into pingcap:master May 8, 2019
@lilin90 lilin90 added the type/refactor The issue belongs to a refactor work. label Jun 19, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants