Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/reference/sql: add sql statements #1425

Merged
merged 23 commits into from
Jun 19, 2019
Merged

dev/reference/sql: add sql statements #1425

merged 23 commits into from
Jun 19, 2019

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 11, 2019 •
edited
Loading

Via:

  • ddl.md, dml.md, transaction.md, admin.md, prepare.md, util.md have been replaced by 73 documents of sql statements.
  • There are 74 documents of sql statements in the docs repository whereas the number in docs-cn repository are 73. The missing one is admin.md.

@TomShawn TomShawn changed the title Tom shawn add sql statements dev/reference/sql: add sql statements Jun 11, 2019
@lilin90 lilin90 mentioned this pull request Jun 12, 2019
Closed
@XuHuaiyu XuHuaiyu mentioned this pull request Jun 12, 2019
Closed
bb7133
bb7133 reviewed Jun 12, 2019
View reviewed changes
dev/reference/sql/statements/add-column.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/add-column.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/add-index.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/add-index.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/add-index.md Outdated Show resolved Hide resolved
TomShawn and others added 2 commits June 13, 2019 10:47
dcalvin
dcalvin reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments in line

dev/reference/sql/statements/commit.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/create-index.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/deallocate.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/delete.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/do.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/do.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/drop-index.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/set-transaction.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/truncate.md Show resolved Hide resolved
dev/reference/sql/statements/show-create-user.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Jun 19, 2019
View reviewed changes
dev/reference/sql/statements/rename-index.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/explain.md Outdated Show resolved Hide resolved
dev/reference/sql/statements/prepare.md Outdated Show resolved Hide resolved
@TomShawn @lilin90
Apply suggestions from code review
353d488 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@TomShawn @lilin90
Update dev/reference/sql/statements/begin.md
cdf7305 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
TomShawn and others added 3 commits June 19, 2019 20:23
lilin90
lilin90 approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the type/refactor The issue belongs to a refactor work. label Jun 19, 2019
@lilin90 lilin90 merged commit 1c3d389 into master Jun 19, 2019
@TomShawn TomShawn deleted the TomShawn-add-sql-statements branch June 19, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@dcalvin dcalvin dcalvin left review comments

@bb7133 bb7133 bb7133 left review comments

@lilin90 lilin90 lilin90 approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
type/refactor The issue belongs to a refactor work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @bb7133 @dcalvin @zz-jason @lilin90