Add introduction of DM's DDL compatibility #9191

sunzhaoyang · 2022-04-26T07:09:12Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-04-26T07:09:13Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lance6716
ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sunzhaoyang · 2022-04-26T07:12:40Z

/cc @lance6716 求专家 review

lance6716 · 2022-04-26T07:16:28Z

dm/dm-ddl-compatible.md

+
+## 改写的 DDL 语句
+
+为了减少报错，以下语句将被改写


这个可以说明一下，纯粹是 dm 内部行为，并不是什么用户需要注意的事情？

lance6716 · 2022-04-26T07:18:03Z

dm/dm-ddl-compatible.md

+
+// 乐观模式不支持以下语句
+"ALTER TABLE table_name ADD COLUMN column_name datatype NOT NULL"（添加无默认值的 not null 的列）。
+"ALTER TABLE table_name ADD COLUMN column_name datetime DEFAULT NOW()"（增加的列默认值不固定）。


印象中除了这个以外，其他的会报错，这个并不会报错

dm/dm-ddl-compatible.md

sunzhaoyang · 2022-04-26T07:35:00Z

/cc @ran-huang

dm/dm-ddl-compatible.md

ran-huang · 2022-04-28T03:33:23Z

dm/dm-ddl-compatible.md

+"^DROP\\s+USER"
+"^SET\\s+PASSWORD"
+
+```


建议写成表格的形式，1）提升可读性 2）便于添加较长的描述性文字

ran-huang · 2022-04-28T03:38:02Z

dm/dm-ddl-compatible.md

+// 自动忽略
+"DROP DATABASE/TABLE"
+"TRUNCATE TABLE"


这两个也是忽略，能否写进 ## 忽略的 DDL 语句 里？

忽略的 DDL 语句, 改写的 DDL 语句, 合库合表迁移任务 这三个标题不是相互独立，完全穷尽的。建议改成 忽略的 DDL 语句, 改写的 DDL 语句, 报错的 DDL 语句（或者其他适用的情况）

dm/dm-ddl-compatible.md

lance6716 · 2022-05-05T12:07:37Z

dm/dm-ddl-compatible.md

+当`shard-mode: pessimistic` 和 `shard-mode: optimistic` 时：
+
+```
+// 自动忽略


这个逻辑在哪里，没记得有😂

https://docs.pingcap.com/zh/tidb/dev/feature-shard-merge-optimistic

这里的描述，合库合表逻辑下忽略 drop 和 truncate

Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: Ran <huangran@pingcap.com>

lance6716 · 2022-05-19T09:18:28Z

dm/dm-ddl-compatible.md

+|`^CREATE TABLE...`|`^CREATE TABLE..IF NOT EXIST`|
+|`^DROP DATABASE...`|`^DROP TABLE...IF EXIST`|
+|`^DROP TABLE...`|`^DROP TABLE...IF EXIST`|
+|`^DROP INDEX...`|`^DROP INDEX...IF EXIST`


ran-huang · 2022-06-16T06:36:36Z

@lance6716 PTAL, thanks

lance6716 · 2022-06-16T06:38:00Z

dm/dm-ddl-compatible.md

+
+<table>
+    <tr>
+        <th>Description</th>


一个中文文档，用洋文 😂

dm/dm-ddl-compatible.md

ran-huang · 2022-06-17T09:51:51Z

/merge

ti-chi-bot · 2022-06-17T09:51:53Z

This pull request has been accepted and is ready to merge.

Commit hash: 9317ebd

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-06-17T09:59:15Z

In response to a cherrypick label: new pull request created: #9890.

ti-chi-bot · 2022-06-17T09:59:52Z

In response to a cherrypick label: new pull request created: #9891.

add-compatible-list

856775a

ti-chi-bot requested a review from TomShawn April 26, 2022 07:09

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2022

add toc

8634e2b

lance6716 reviewed Apr 26, 2022

View reviewed changes

sunzhaoyang commented Apr 26, 2022

View reviewed changes

dm/dm-ddl-compatible.md Outdated Show resolved Hide resolved

sunzhaoyang commented Apr 26, 2022

View reviewed changes

dm/dm-ddl-compatible.md Outdated Show resolved Hide resolved

Apply suggestions from code review

8a686e6

ti-chi-bot requested a review from ran-huang April 26, 2022 07:35

ran-huang added area/dm translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 labels Apr 27, 2022

ran-huang self-assigned this Apr 27, 2022

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 27, 2022

ran-huang reviewed Apr 28, 2022

View reviewed changes

ran-huang removed the request for review from TomShawn April 28, 2022 03:39

lance6716 reviewed May 5, 2022

View reviewed changes

sunzhaoyang and others added 3 commits May 12, 2022 13:33

Apply suggestions from code review

5782fcc

Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: Ran <huangran@pingcap.com>

Update dm-ddl-compatible.md

eda8a9e

Update dm-ddl-compatible.md

588a036

sunzhaoyang requested review from ran-huang and lance6716 May 19, 2022 06:20

lance6716 reviewed May 19, 2022

View reviewed changes

Update dm-ddl-compatible.md

ab3bf3f

sunzhaoyang requested a review from lance6716 May 20, 2022 02:49

ran-huang approved these changes Jun 16, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2022

ran-huang removed the needs-cherry-pick-release-6.0 label Jun 16, 2022

lance6716 approved these changes Jun 16, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2022

Update dm/dm-ddl-compatible.md

9c7a434

ran-huang reviewed Jun 17, 2022

View reviewed changes

dm/dm-ddl-compatible.md Outdated Show resolved Hide resolved

Update dm/dm-ddl-compatible.md

9317ebd

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022

ti-chi-bot merged commit f681fd5 into pingcap:master Jun 17, 2022

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 17, 2022

This is an automated cherry-pick of pingcap#9191

c045c75

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 17, 2022

Add introduction of DM's DDL compatibility (#9191) #9890

Merged

17 tasks

ti-chi-bot mentioned this pull request Jun 17, 2022

Add introduction of DM's DDL compatibility (#9191) #9891

Merged

17 tasks

ti-chi-bot added a commit that referenced this pull request Jun 17, 2022

Add introduction of DM's DDL compatibility (#9191) (#9890)

070392d

ti-chi-bot added a commit that referenced this pull request Jun 17, 2022

Add introduction of DM's DDL compatibility (#9191) (#9891)

a5d3f08

ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 17, 2023

ran-huang mentioned this pull request Jan 17, 2023

dm: add doc for dm's ddl compatibility pingcap/docs#12097

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add introduction of DM's DDL compatibility #9191

Add introduction of DM's DDL compatibility #9191

sunzhaoyang commented Apr 26, 2022 •

edited by ran-huang

Loading

ti-chi-bot commented Apr 26, 2022 •

edited

Loading

sunzhaoyang commented Apr 26, 2022

lance6716 Apr 26, 2022

lance6716 Apr 26, 2022

sunzhaoyang commented Apr 26, 2022

ran-huang Apr 28, 2022

ran-huang Apr 28, 2022

lance6716 May 5, 2022

sunzhaoyang May 11, 2022

lance6716 May 19, 2022

ran-huang commented Jun 16, 2022

lance6716 Jun 16, 2022

ran-huang commented Jun 17, 2022

ti-chi-bot commented Jun 17, 2022

ti-chi-bot commented Jun 17, 2022

ti-chi-bot commented Jun 17, 2022


		## 改写的 DDL 语句

		为了减少报错，以下语句将被改写

	\|`^DROP INDEX...`\|`^DROP INDEX...IF EXIST`
	\|`^DROP INDEX...`\|`^DROP INDEX...IF EXIST`\|

Add introduction of DM's DDL compatibility #9191

Add introduction of DM's DDL compatibility #9191

Conversation

sunzhaoyang commented Apr 26, 2022 • edited by ran-huang Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Apr 26, 2022 • edited Loading

sunzhaoyang commented Apr 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunzhaoyang commented Apr 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ran-huang commented Jun 16, 2022

Choose a reason for hiding this comment

ran-huang commented Jun 17, 2022

ti-chi-bot commented Jun 17, 2022

ti-chi-bot commented Jun 17, 2022

ti-chi-bot commented Jun 17, 2022

sunzhaoyang commented Apr 26, 2022 •

edited by ran-huang

Loading

ti-chi-bot commented Apr 26, 2022 •

edited

Loading