dm: add dml replication logic #9121

ran-huang · 2022-04-22T10:56:51Z

What is changed, added or deleted? (Required)

Add a doc for DML replication logic.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: Ran <huangran@pingcap.com>

ti-chi-bot · 2022-04-22T10:56:53Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lance6716
shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

dm/dm-dml-replication-logic.md

sunzhaoyang · 2022-04-23T09:09:42Z

TOC.md

@@ -351,6 +351,8 @@
          - [DM 架构简介](/dm/dm-arch.md)
          - [DM-worker 说明](/dm/dm-worker-intro.md)
          - [Relay Log](/dm/relay-log.md)
+        - 同步机制


这个二级菜单我觉得要再讨论下。一方面有些文档我直接放在架构下面，不怎么合适。另一方面”同步机制“貌似只会有这么一两篇文档，也比较鸡肋。

或者我们考虑改成内部机制，运行机制，或者其他的名字，把其他分类不太好的也移过来

“内部机制”或者“原理”？

"运行机制" or ”原理解读“? 你喜欢哪个？

运行机制吧

dm/dm-dml-replication-logic.md

sunzhaoyang · 2022-04-23T09:30:36Z

/cc @lance6716 PTAL

ti-chi-bot · 2022-04-23T09:30:38Z

@sunzhaoyang: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lance6716 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dm/dm-dml-replication-logic.md

Co-authored-by: sunzy <sunzy2@gmail.com> Co-authored-by: lance6716 <lance6716@gmail.com>

dm/dm-dml-replication-logic.md

Co-authored-by: sunzy <sunzy2@gmail.com>

dm/dm-dml-replication-logic.md

TOC.md

sunzhaoyang

LGTM

ran-huang · 2022-06-20T02:12:40Z

/merge

ti-chi-bot · 2022-06-20T02:12:43Z

This pull request has been accepted and is ready to merge.

Commit hash: 825682b

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-06-20T02:19:13Z

In response to a cherrypick label: new pull request created: #9895.

ti-chi-bot · 2022-06-20T02:19:51Z

In response to a cherrypick label: new pull request created: #9896.

ti-chi-bot · 2022-06-20T02:20:31Z

In response to a cherrypick label: new pull request created: #9897.

ran-huang added 2 commits April 22, 2022 18:48

dm: add dml replication logic

5c71cd7

Signed-off-by: Ran <huangran@pingcap.com>

add image

c8443f2

Signed-off-by: Ran <huangran@pingcap.com>

ran-huang added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. area/dm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 labels Apr 22, 2022

ran-huang requested review from sunzhaoyang and GMHDBJD April 22, 2022 10:56

ran-huang self-assigned this Apr 22, 2022

ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2022

ran-huang commented Apr 22, 2022

View reviewed changes

dm/dm-dml-replication-logic.md Show resolved Hide resolved

sunzhaoyang reviewed Apr 23, 2022

View reviewed changes

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

sunzhaoyang added 2 commits April 23, 2022 17:20

Update dm-dml-replication-logic.md

536d321

Update dm-dml-replication-logic.md

aa9d58c

sunzhaoyang reviewed Apr 23, 2022

View reviewed changes

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

ti-chi-bot requested a review from lance6716 April 23, 2022 09:30

lance6716 reviewed Apr 24, 2022

View reviewed changes

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

dm/dm-dml-replication-logic.md Show resolved Hide resolved

Apply suggestions from code review

b071748

Co-authored-by: sunzy <sunzy2@gmail.com> Co-authored-by: lance6716 <lance6716@gmail.com>

sunzhaoyang reviewed Apr 24, 2022

View reviewed changes

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

Update dm/dm-dml-replication-logic.md

d28aedc

Co-authored-by: sunzy <sunzy2@gmail.com>

ran-huang requested review from lance6716 and sunzhaoyang April 27, 2022 09:03

lance6716 approved these changes May 5, 2022

View reviewed changes

dm/dm-dml-replication-logic.md Outdated Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022

sunzhaoyang reviewed May 11, 2022

View reviewed changes

TOC.md Outdated Show resolved Hide resolved

Update dm/dm-dml-replication-logic.md

4f1c49d

ran-huang added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 6, 2022

ran-huang requested a review from sunzhaoyang June 15, 2022 12:42

sunzhaoyang approved these changes Jun 17, 2022

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2022

Merge branch 'master' into dm-sync

825682b

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022

ti-chi-bot merged commit e497f92 into pingcap:master Jun 20, 2022

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 20, 2022

This is an automated cherry-pick of pingcap#9121

fddcdff

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 20, 2022

dm: add dml replication logic (#9121) #9895

Closed

16 tasks

ti-chi-bot mentioned this pull request Jun 20, 2022

dm: add dml replication logic (#9121) #9896

Merged

16 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 20, 2022

dm: add dml replication logic (pingcap#9121)

1eb1742

ti-chi-bot mentioned this pull request Jun 20, 2022

dm: add dml replication logic (#9121) #9897

Merged

16 tasks

ti-chi-bot added a commit that referenced this pull request Jun 20, 2022

dm: add dml replication logic (#9121) (#9897)

a44adc6

ti-chi-bot added a commit that referenced this pull request Jun 20, 2022

dm: add dml replication logic (#9121) (#9896)

01bd0f4

ran-huang deleted the dm-sync branch January 17, 2023 08:41

ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 19, 2023

ran-huang mentioned this pull request Jan 19, 2023

dm: add dml replication logic pingcap/docs#12188

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dm: add dml replication logic #9121

dm: add dml replication logic #9121

ran-huang commented Apr 22, 2022

ti-chi-bot commented Apr 22, 2022 •

edited

Loading

sunzhaoyang Apr 23, 2022

ran-huang Apr 24, 2022

sunzhaoyang Apr 24, 2022

ran-huang Apr 27, 2022

sunzhaoyang commented Apr 23, 2022

ti-chi-bot commented Apr 23, 2022

sunzhaoyang left a comment

ran-huang commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

dm: add dml replication logic #9121

dm: add dml replication logic #9121

Conversation

ran-huang commented Apr 22, 2022

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Apr 22, 2022 • edited Loading

sunzhaoyang Apr 23, 2022

Choose a reason for hiding this comment

ran-huang Apr 24, 2022

Choose a reason for hiding this comment

sunzhaoyang Apr 24, 2022

Choose a reason for hiding this comment

ran-huang Apr 27, 2022

Choose a reason for hiding this comment

sunzhaoyang commented Apr 23, 2022

ti-chi-bot commented Apr 23, 2022

sunzhaoyang left a comment

Choose a reason for hiding this comment

ran-huang commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Jun 20, 2022

ti-chi-bot commented Apr 22, 2022 •

edited

Loading