Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Tuning Guide #9067

Merged
merged 47 commits into from
May 11, 2022
Merged

Performance Tuning Guide #9067

merged 47 commits into from
May 11, 2022

Conversation

dbsid
Copy link
Contributor

@dbsid dbsid commented Apr 19, 2022 •
edited by qiancai
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@dbsid dbsid marked this pull request as draft April 19, 2022 05:37
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 19, 2022 05:37
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 19, 2022
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Apr 19, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 19, 2022
@qiancai qiancai added needs-cherry-pick-release-6.0 area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. type/enhancement The issue or PR belongs to an enhancement. labels Apr 19, 2022
@qiancai qiancai requested review from qiancai and removed request for TomShawn April 19, 2022 08:41
@qiancai qiancai self-assigned this Apr 19, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2022
@qiancai qiancai marked this pull request as ready for review May 11, 2022 09:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2022
@qiancai
Copy link
Collaborator

qiancai commented May 11, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2022
@qiancai
Copy link
Collaborator

qiancai commented May 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 44bae50

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2022
@ti-chi-bot ti-chi-bot merged commit 075ba84 into master May 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2022
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9417.

@qiancai qiancai deleted the performance-overview branch May 11, 2022 09:40
qiancai added a commit that referenced this pull request May 11, 2022
@ti-chi-bot @dbsid
@qiancai @Yui-Song
Performance Tuning Guide (#9067) (#9417)
850ed26 
* initial commit for the performance overview

* finish the db time and qps part

* add duration metrics intro

* add tikv write documents

* finish the drat version

* minor enhancements

* review and improvements

* split into overview and guideline

* change filename from guideline to guide

* add "tuning by color" method

* improve overview

* minor enhancements

* improvements

* add doc for performance overview dashboard

* Add TOC entry

* enhance the dashboard descriptions

* Apply suggestions from code review

* update_content_from_writing_perspective

* Update grafana-performance-overview-dashboard.md

* fix broken links

* Update grafana-performance-overview-dashboard.md

* update punctuation

* Update performance-tuning-methods.md

* Update performance-tuning-methods.md

accept suggestion

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update performance-tuning-methods.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update performance-tuning-methods.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update performance-tuning-methods.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* add example 4 for db time overview

* Update performance-tuning-methods.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update performance-tuning-methods.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* fix CI error

* fix the wrong image for prepared_statement_no_plan_cache

* update performance-tuning-overview.md

* update grafana-performance-overview-dashboard.md

* update performance-tuning-methods.md

* Update performance-tuning-methods.md

* fix link error

* Revert "fix link error"

This reverts commit 3e0ea40.

* update dashboard-diagnostics-time-relation.png

* update color description for db time by sql type, add description for plan cache

* fix link

* correct the picture due the color change of commit

* Update performance-tuning-methods.md

* minor wording updates

* �fix a broken link and make some minor wording changes

Co-authored-by: dbsid <huanshengchen@gmail.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Yui-Song <84501897+Yui-Song@users.noreply.github.com>
@qiancai qiancai mentioned this pull request May 30, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 mentioned this pull request Jun 3, 2022
Merged
14 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 10, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 mentioned this pull request Jun 10, 2022
Merged
14 tasks
This was referenced Jun 13, 2022
Merged
Merged
@qiancai qiancai removed the translation/doing This PR’s assignee is translating this PR. label Jul 1, 2022
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Jul 1, 2022
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yui-Song Yui-Song Yui-Song approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

@shichun-0415 shichun-0415

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbsid @ti-chi-bot @qiancai @Yui-Song @shichun-0415