Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiDB Dashboard: Polish v6.0 features #8889

Merged
merged 12 commits into from
Apr 14, 2022
Merged

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Apr 7, 2022

Signed-off-by: Wish breezewish@outlook.com

What is changed, added or deleted? (Required)

  • Update both manual profiling and continuous profiling document to better illustrate their relationship.

  • Add some notice about TiFlash CPU profiling.

  • Polished the detail text of Top SQL.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: (I will translate by my own)
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 7, 2022 06:37
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2022
Signed-off-by: Wish <breezewish@outlook.com>
@TomShawn TomShawn requested review from crazycs520 and removed request for TomShawn April 7, 2022 09:08
@TomShawn TomShawn added area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-6.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 7, 2022
Signed-off-by: Wish <breezewish@outlook.com>
@breezewish breezewish changed the title TiDB Dashboard: Unify the document about manual profiling and continuous profiling TiDB Dashboard: Polish v6.0 features Apr 7, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2022
basic-features.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Show resolved Hide resolved
dashboard/dashboard-profiling.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Lux <fenhuilihe@gmail.com>
@shichun-0415
Copy link
Contributor

/verify

@shichun-0415 shichun-0415 requested a review from SunRunAway April 13, 2022 02:38
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
dashboard/top-sql.md Outdated Show resolved Hide resolved
dashboard/top-sql.md Outdated Show resolved Hide resolved
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 14, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9573ab5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@shichun-0415 shichun-0415 merged commit 4f11ee7 into master Apr 14, 2022
@shichun-0415 shichun-0415 deleted the update-dashboard-profiling branch April 14, 2022 01:56
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 14, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8980.

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Apr 14, 2022
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 14, 2022
@shichun-0415 shichun-0415 mentioned this pull request Nov 4, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants