Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add introduction of dm relay log #8780

Merged
merged 18 commits into from
Jun 17, 2022
Merged

Add introduction of dm relay log #8780

merged 18 commits into from
Jun 17, 2022

Conversation

sunzhaoyang
Copy link
Contributor

@sunzhaoyang sunzhaoyang commented Mar 29, 2022 •
edited by ran-huang
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 29, 2022 08:55
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@sunzhaoyang
Copy link
Contributor Author

/cc @Ehco1996 @GMHDBJD @shichun-0415

@TomShawn TomShawn requested review from ran-huang and removed request for TomShawn March 30, 2022 02:32
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. area/dm and removed missing-translation-status This PR does not have translation status info. labels Mar 30, 2022
Ehco1996
Ehco1996 reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有其他地方有些排版的问题 麻烦文档老师 review 吧

@sunzhaoyang @Ehco1996
Apply suggestions from code review
e01f0dd 
Co-authored-by: Ehco <zh19960202@gmail.com>
sunzhaoyang
sunzhaoyang commented Apr 8, 2022
View reviewed changes
ran-huang
ran-huang reviewed Apr 20, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
@sunzhaoyang sunzhaoyang requested a review from ran-huang April 20, 2022 13:23
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
ran-huang
ran-huang reviewed Apr 27, 2022
View reviewed changes
@sunzhaoyang @ran-huang
Apply suggestions from code review
89a93d4 
Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang
update wording and format
113d2dd 
Signed-off-by: Ran <huangran.alex@gmail.com>
ran-huang
ran-huang reviewed Jun 15, 2022
View reviewed changes
dm/relay-log.md Outdated

- DM-worker 把从上游数据库迁移到的 binlog 存储在同一目录下，每个目录都为一个 `subdir`。
- `subdir` 的命名格式为 `<上游数据库 UUID>.<本地 subdir 序列号>`。
- 在上游进行 master 和 slave 实例切换后，DM-worker 会生成一个序号递增的新 `subdir` 目录。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master / slave 是指什么呢？
如果没有特殊的情况，现在一般要求用 source/replica（与 mysql 一致）或者 primary/secondary。

@ran-huang
Copy link
Contributor

@sunzhaoyang please confirm the changes in 113d2dd. Rest LGTM

@ran-huang ran-huang added needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jun 15, 2022
sunzhaoyang
sunzhaoyang commented Jun 16, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2022
@ran-huang
Copy link
Contributor

@Ehco1996 PTAL, thanks. Please approve this PR if you think it's technically correct.

Ehco1996
Ehco1996 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 10c7267

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@ran-huang ran-huang merged commit 2856a35 into pingcap:master Jun 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 17, 2022
@sunzhaoyang @ti-chi-bot
This is an automated cherry-pick of pingcap#8780
eb3542e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 17, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9885.

ti-chi-bot added a commit that referenced this pull request Jun 17, 2022
@ti-chi-bot
Add introduction of dm relay log (#8780) (#9885)
f07a5e2
@ran-huang ran-huang mentioned this pull request May 5, 2023
Merged
16 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 6, 2023
This was referenced May 17, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 left review comments

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@ran-huang ran-huang ran-huang approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees

@ran-huang ran-huang

Labels
area/dm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sunzhaoyang @ti-chi-bot @ran-huang @Ehco1996 @shichun-0415 @TomShawn