Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise expressions pushed down #8684

Merged
merged 14 commits into from
Mar 24, 2022
Merged

revise expressions pushed down #8684

merged 14 commits into from
Mar 24, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Mar 16, 2022

Signed-off-by: yisaer disxiaofei@163.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Yisaer
revise
c5f262e 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • en-jin19

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 16, 2022 03:04
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@TomShawn
Copy link
Contributor

@Yisaer 是否为 v6.0 相关的呢？请@ tech review 吧，谢谢~

@xiejiandong
Copy link

lgtm

@TomShawn TomShawn requested review from en-jin19 and removed request for TomShawn March 17, 2022 02:34
@TomShawn TomShawn added area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. translation/doing This PR’s assignee is translating this PR. v6.0 This PR/issue applies to TiDB v6.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 17, 2022
@Yisaer
address the comment
96d2e65 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from winoros March 17, 2022 04:15
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@en-jin19 en-jin19 added the status/PTAL This PR is ready for reviewing. label Mar 22, 2022
en-jin19
en-jin19 reviewed Mar 23, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022
en-jin19
en-jin19 reviewed Mar 24, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 24, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@en-jin19
Copy link
Contributor

/merge

@en-jin19 en-jin19 added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@en-jin19 en-jin19 removed the status/PTAL This PR is ready for reviewing. label Mar 24, 2022
@en-jin19
Copy link
Contributor

/merge

1 similar comment
@ran-huang
Copy link
Contributor

/merge

@ran-huang ran-huang closed this Mar 24, 2022
@ran-huang ran-huang reopened this Mar 24, 2022
@ran-huang
Copy link
Contributor

/merge

3 similar comments
@TomShawn
Copy link
Contributor

/merge

@TomShawn
Copy link
Contributor

/merge

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8628afc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@ti-chi-bot ti-chi-bot merged commit 503f755 into pingcap:master Mar 24, 2022
@en-jin19 en-jin19 mentioned this pull request Mar 24, 2022
Merged
15 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 24, 2022
@en-jin19 en-jin19 mentioned this pull request Mar 24, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en-jin19 en-jin19 en-jin19 approved these changes

@TomShawn TomShawn TomShawn approved these changes

@winoros winoros winoros approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Yisaer @ti-chi-bot @TomShawn @xiejiandong @en-jin19 @ran-huang @winoros