Fix the descriptions about comment length in table, column, and index #8059

CbcWestwolf · 2021-12-25T06:33:31Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

The related PR in tidb: pingcap/tidb#30973

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-12-25T06:33:33Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn
tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CLAassistant · 2021-12-25T06:33:36Z

All committers have signed the CLA.

sql-statements/sql-statement-create-index.md

sql-statements/sql-statement-create-table.md

Co-authored-by: wjHuang <huangwenjun1997@gmail.com>

CbcWestwolf · 2022-01-05T04:37:46Z

@wjhuang2016 @tangenta PTAL

djshow832

The TiDB PR won't be cherry-picked to 5.3 or 5.4, so this modification only affects the master branch of docs.

djshow832 · 2022-01-05T08:24:09Z

sql-statements/sql-statement-create-index.md

@@ -301,6 +301,7 @@ CREATE UNIQUE INDEX c1 ON t1 (c1) INVISIBLE;
 * 无法向表中添加 `CLUSTERED` 类型的 `PRIMARY KEY`。要了解关于 `CLUSTERED` 主键的详细信息，请参考[聚簇索引](/clustered-indexes.md)。
 * 表达式索引与视图存在兼容性问题。通过视图进行查询时，无法使用上表达式索引。
 * 表达式索引与 Binding 存在兼容性问题。当表达式索引中的表达式存在常量时，对应查询所建的 Binding 会扩大范围。假设表达式索引中的表达式为 `a+1`，对应的查询条件为 `a+1 > 2`。则建立的 Binding 为 `a+? > ?`，这会导致像 `a+2 > 2` 这样的查询也会强制使用表达式索引，得到一个较差的执行计划。这同样影响 SQL Plan Management (SPM) 中的捕获和演进功能。
+* 索引的 `COMMENT` 属性最多支持 1024 个字符。


This is exactly the same with MySQL, so we don't need to declare it.

djshow832 · 2022-01-05T08:27:31Z

sql-statements/sql-statement-create-table.md

@@ -191,7 +191,7 @@ mysql> DESC t1;
 * 不支持 `FULLTEXT`，`HASH` 和 `SPATIAL` 索引。
 * 为了与 MySQL 兼容，`index_col_name` 属性支持 length 选项，最大长度默认限制为 3072 字节。此长度限制可以通过配置项 `max-index-length` 更改，具体请参阅 [TiDB 配置文件描述](/tidb-configuration-file.md#max-index-length)。
 * 为了与 MySQL 兼容，TiDB 会解析但忽略 `index_col_name` 属性的 `[ASC | DESC]` 索引排序选项。
-* `COMMENT` 属性最多支持 1024 个字符，不支持 `WITH PARSER` 选项。
+* 表的 `COMMENT` 属性最多支持 2048 个字符；列的 `COMMENT` 属性最多支持 1024 个字符，不支持 `WITH PARSER` 选项。


What about the index comment and table partition comment?
I think it's fine to remove the declaration because it now keeps the same with MySQL.

ti-chi-bot · 2022-01-13T08:40:27Z

@CbcWestwolf: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

tangenta · 2022-01-13T09:17:30Z

/merge

ti-chi-bot · 2022-01-13T09:17:33Z

This pull request has been accepted and is ready to merge.

Commit hash: 85f634f

ti-chi-bot · 2022-01-13T09:18:21Z

In response to a cherrypick label: new pull request created: #8150.

…#8059) (#8150)

Fix the descriptions about comment length in table, column, and index

9fcf70e

ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 25, 2021

ti-chi-bot requested a review from TomShawn December 25, 2021 06:33

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 25, 2021

TomShawn requested review from tangenta and wjhuang2016 December 27, 2021 01:55

TomShawn self-assigned this Dec 27, 2021

wjhuang2016 reviewed Dec 27, 2021

View reviewed changes

sql-statements/sql-statement-create-index.md Outdated Show resolved Hide resolved

sql-statements/sql-statement-create-table.md Outdated Show resolved Hide resolved

CbcWestwolf and others added 2 commits December 27, 2021 12:37

Update sql-statements/sql-statement-create-index.md

906dcb6

Co-authored-by: wjHuang <huangwenjun1997@gmail.com>

Update sql-statements/sql-statement-create-table.md

ea5441c

Co-authored-by: wjHuang <huangwenjun1997@gmail.com>

TomShawn approved these changes Dec 27, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 27, 2021

djshow832 reviewed Jan 5, 2022

View reviewed changes

CbcWestwolf added 2 commits January 5, 2022 16:55

Update sql-statement-create-index.md

afac5bd

Update sql-statement-create-table.md

85f634f

tangenta approved these changes Jan 5, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 5, 2022

pingcap deleted a comment from ti-chi-bot Jan 5, 2022

wjhuang2016 approved these changes Jan 6, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2022

ti-chi-bot merged commit 1cf54dd into pingcap:master Jan 13, 2022

ti-chi-bot mentioned this pull request Jan 13, 2022

Fix the descriptions about comment length in table, column, and index (#8059) #8150

Merged

14 tasks

TomShawn removed the area/general Relates to TiDB overview, architecture, and other general descriptions. label Jan 14, 2022

ti-chi-bot added a commit that referenced this pull request Jan 14, 2022

Fix the descriptions about comment length in table, column, and index (…

dd7f8c2

…#8059) (#8150)

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 8, 2022

TomShawn mentioned this pull request Feb 8, 2022

Align 4 PRs pingcap/docs#7521

Merged

14 tasks

ti-chi-bot mentioned this pull request Feb 9, 2022

Align 4 PRs (#7521) pingcap/docs#7522

Merged

14 tasks

CbcWestwolf deleted the max_comment_length branch March 11, 2022 02:40

This was referenced Jun 14, 2024

Fix an error (#7521) pingcap/docs#17898

Merged

Fix an error (#7521) pingcap/docs#17899

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the descriptions about comment length in table, column, and index #8059

Fix the descriptions about comment length in table, column, and index #8059

CbcWestwolf commented Dec 25, 2021 •

edited

Loading

ti-chi-bot commented Dec 25, 2021 •

edited

Loading

CLAassistant commented Dec 25, 2021 •

edited

Loading

CbcWestwolf commented Jan 5, 2022 •

edited

Loading

djshow832 left a comment •

edited

Loading

djshow832 Jan 5, 2022

CbcWestwolf Jan 5, 2022

djshow832 Jan 5, 2022

CbcWestwolf Jan 5, 2022

ti-chi-bot commented Jan 13, 2022

tangenta commented Jan 13, 2022

ti-chi-bot commented Jan 13, 2022

ti-chi-bot commented Jan 13, 2022

Fix the descriptions about comment length in table, column, and index #8059

Fix the descriptions about comment length in table, column, and index #8059

Conversation

CbcWestwolf commented Dec 25, 2021 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Dec 25, 2021 • edited Loading

CLAassistant commented Dec 25, 2021 • edited Loading

CbcWestwolf commented Jan 5, 2022 • edited Loading

djshow832 left a comment • edited Loading

Choose a reason for hiding this comment

djshow832 Jan 5, 2022

Choose a reason for hiding this comment

CbcWestwolf Jan 5, 2022

Choose a reason for hiding this comment

djshow832 Jan 5, 2022

Choose a reason for hiding this comment

CbcWestwolf Jan 5, 2022

Choose a reason for hiding this comment

ti-chi-bot commented Jan 13, 2022

tangenta commented Jan 13, 2022

ti-chi-bot commented Jan 13, 2022

ti-chi-bot commented Jan 13, 2022

CbcWestwolf commented Dec 25, 2021 •

edited

Loading

ti-chi-bot commented Dec 25, 2021 •

edited

Loading

CLAassistant commented Dec 25, 2021 •

edited

Loading

CbcWestwolf commented Jan 5, 2022 •

edited

Loading

djshow832 left a comment •

edited

Loading