Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in sync diff #7928

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

Rustin170506
Copy link
Member

Signed-off-by: hi-rustin rustin.liu@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix a typo in sync diff.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

close #7906

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

None

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 14, 2021 03:15
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2021
@Rustin170506
Copy link
Member Author

/cc @Leavrth
Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

@ti-chi-bot ti-chi-bot requested a review from Leavrth December 14, 2021 03:16
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2021
@TomShawn TomShawn added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. and removed missing-translation-status This PR does not have translation status info. labels Dec 14, 2021
@shichun-0415 shichun-0415 added the ONCALL Relates to documentation oncall. label Dec 14, 2021
@ti-chi-bot
Copy link
Member

@Leavrth: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hfxsd
Copy link
Collaborator

hfxsd commented Dec 14, 2021

/merge

@ti-chi-bot
Copy link
Member

@hfxsd: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2021
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 14, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e98a93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2021
@ti-chi-bot ti-chi-bot merged commit e6ced77 into pingcap:master Dec 14, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2021
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7932.

ti-chi-bot added a commit that referenced this pull request Dec 14, 2021
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 23, 2022
@hfxsd hfxsd mentioned this pull request Mar 23, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文档列子书写有错
6 participants