Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release-5.3.0.md #7808

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Update release-5.3.0.md #7808

merged 2 commits into from
Dec 6, 2021

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Dec 6, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Corrected a unit error.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd requested a review from qiancai December 6, 2021 02:21
@ti-chi-bot ti-chi-bot requested a review from TomShawn December 6, 2021 02:21
@hfxsd hfxsd self-assigned this Dec 6, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2021
@hfxsd hfxsd added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Dec 6, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed missing-translation-status This PR does not have translation status info. labels Dec 6, 2021
@hfxsd hfxsd added needs-cherry-pick-release-5.3 type/bugfix This PR fixes a bug. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. labels Dec 6, 2021
@hfxsd hfxsd requested a review from glorv December 6, 2021 02:23
@ti-chi-bot
Copy link
Member

@sunzhaoyang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

glorv
glorv reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Dec 6, 2021
View reviewed changes
releases/release-5.3.0.md Outdated Show resolved Hide resolved
@hfxsd @TomShawn
Update releases/release-5.3.0.md
668e17d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@hfxsd: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@hfxsd: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 6, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 6, 2021
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 668e17d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2021
@ti-chi-bot ti-chi-bot merged commit b1f969a into pingcap:master Dec 6, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7809.

ti-chi-bot added a commit that referenced this pull request Dec 6, 2021
@ti-chi-bot
Update release-5.3.0.md (#7808) (#7809)
86f0c25
@hfxsd hfxsd linked an issue Dec 6, 2021 that may be closed by this pull request
TiDB Lightning 并行导入速度问题，应是 250G /hour，非 250G /s #7806
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@glorv glorv glorv left review comments

@sunzhaoyang sunzhaoyang sunzhaoyang approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees

@hfxsd hfxsd

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB Lightning 并行导入速度问题，应是 250G /hour，非 250G /s
5 participants
@hfxsd @ti-chi-bot @sunzhaoyang @glorv @TomShawn