Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs templates for reference #7569

Merged
merged 21 commits into from
Dec 9, 2021
Merged

add docs templates for reference #7569

merged 21 commits into from
Dec 9, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Liuxiaozhen12 Liuxiaozhen12 added the translation/doing This PR’s assignee is translating this PR. label Nov 21, 2021
@Liuxiaozhen12 Liuxiaozhen12 self-assigned this Nov 21, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2021
hfxsd
hfxsd approved these changes Nov 23, 2021
View reviewed changes
.github/concept_template.md Outdated Show resolved Hide resolved
.github/new_feature_template.md Outdated Show resolved Hide resolved
.github/new_feature_template.md Outdated Show resolved Hide resolved
.github/reference_template.md Outdated Show resolved Hide resolved
.github/new_feature_template.md Outdated Show resolved Hide resolved
.github/task_template.md Outdated Show resolved Hide resolved
.github/task_template.md Outdated Show resolved Hide resolved
.github/task_template.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2021
Liuxiaozhen12 and others added 2 commits November 23, 2021 11:09
@Liuxiaozhen12 @hfxsd
Apply suggestions from code review
325e3aa 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
address comments
87eaabc
shichun-0415
shichun-0415 reviewed Nov 24, 2021
View reviewed changes
.github/concept_template.md Outdated Show resolved Hide resolved
.github/concept_template.md Outdated Show resolved Hide resolved
.github/concept_template.md Outdated Show resolved Hide resolved
.github/new_feature_template.md Outdated Show resolved Hide resolved
.github/new_feature_template.md Outdated Show resolved Hide resolved
.github/new_feature_template.md Outdated Show resolved Hide resolved
@pingcap pingcap deleted a comment from shichun-0415 Nov 24, 2021
@pingcap pingcap deleted a comment from shichun-0415 Nov 24, 2021
@pingcap pingcap deleted a comment from shichun-0415 Nov 24, 2021
Liuxiaozhen12 and others added 4 commits November 25, 2021 10:57
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2021
@TomShawn TomShawn added status/require-change Needs the author to address comments. status/WIP This PR is still working in progress. labels Dec 6, 2021
qiancai and others added 13 commits December 8, 2021 14:02
@qiancai qiancai removed status/WIP This PR is still working in progress. status/require-change Needs the author to address comments. labels Dec 9, 2021
@qiancai
Copy link
Collaborator

qiancai commented Dec 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c4e613

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2021
@ti-chi-bot ti-chi-bot merged commit 9b63dee into pingcap:master Dec 9, 2021
@shichun-0415 shichun-0415 added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai left review comments

@shichun-0415 shichun-0415 shichun-0415 left review comments

@TomShawn TomShawn TomShawn approved these changes

@en-jin19 en-jin19 Awaiting requested review from en-jin19

Assignees

@shichun-0415 shichun-0415

Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Liuxiaozhen12 @ti-chi-bot @qiancai @lilin90 @hfxsd @TomShawn @shichun-0415