Skip to content

update sync_diff_inspector: sync_diff_inspector v2.0 - #7353

Merged
ti-chi-bot merged 34 commits into
pingcap:masterfrom
Leavrth:diff2
Nov 5, 2021
Merged

update sync_diff_inspector: sync_diff_inspector v2.0#7353
ti-chi-bot merged 34 commits into
pingcap:masterfrom
Leavrth:diff2

Conversation

@Leavrth

@Leavrth Leavrth commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

sync_diff_inspector upgrades to v2.0

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 29, 2021
@ti-chi-bot
ti-chi-bot requested a review from TomShawn October 29, 2021 08:20
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 29, 2021
@Liuxiaozhen12 Liuxiaozhen12 self-assigned this Oct 29, 2021
@Liuxiaozhen12
Liuxiaozhen12 requested review from Liuxiaozhen12 and removed request for TomShawn October 29, 2021 08:59
@Liuxiaozhen12 Liuxiaozhen12 added translation/doing This PR’s assignee is translating this PR. v5.3 This PR/issue applies to TiDB v5.3. labels Oct 29, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 29, 2021
@3pointer
3pointer requested a review from zier-one October 29, 2021 09:05
@3pointer

3pointer commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

@leoppro PTAL

@Leavrth
Merge pull request #1 from zwj-coder/master
be43e1e 
update sync_diff_inspector2 docs
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2021
@Liuxiaozhen12

Liuxiaozhen12 commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

@Leavrth I've updated the docs but some expressions still require you to complete. PTAL~

Liuxiaozhen12
Liuxiaozhen12 reviewed Nov 5, 2021
View reviewed changes
Comment thread sync-diff-inspector/dm-diff.md Outdated
Liuxiaozhen12
Liuxiaozhen12 reviewed Nov 5, 2021
View reviewed changes
Comment thread TOC.md Outdated
@Liuxiaozhen12

Liuxiaozhen12 commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

/verify

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@Liuxiaozhen12

Liuxiaozhen12 commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2021
zier-one
zier-one reviewed Nov 5, 2021
View reviewed changes
Comment thread sync-diff-inspector/shard-diff.md Outdated
@Liuxiaozhen12

Liuxiaozhen12 commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot commented Nov 5, 2021

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 98c7f02

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2021
@ti-chi-bot
ti-chi-bot merged commit 7a44ab9 into pingcap:master Nov 5, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Nov 10, 2021
Merged
14 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 10, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Nov 15, 2021
Merged
14 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2021
Closed
14 tasks
@Leavrth
Leavrth deleted the diff2 branch November 21, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer left review comments
+3 more reviewers
@zier-one zier-one zier-one left review comments
@TomShawn TomShawn TomShawn left review comments
@Liuxiaozhen12 Liuxiaozhen12 Liuxiaozhen12 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.3 This PR/issue applies to TiDB v5.3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Leavrth @ti-chi-bot @3pointer @Liuxiaozhen12 @zier-one @TomShawn @Relax4Life