update sync-diff-inspector: update settings docs #7510

Leavrth · 2021-11-15T08:19:52Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Table configs of settings has been updated.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): sync-diff: add an tablefilter for table config tidb-tools#546 & update sync_diff_inspector: sync_diff_inspector v2.0 #7353

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-11-15T08:19:53Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

3pointer
Liuxiaozhen12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Leavrth · 2021-11-15T08:24:23Z

sync-diff-inspector/sync-diff-inspector-overview.md

+# 指定检查的数据的范围，需要符合 sql 中 where 条件的语法
+range = "age > 10 AND age < 20"
+# 指定用于划分 chunk 的列，如果不配置该项，sync-diff-inspector 会选取一些合适的列（主键／唯一键／索引）
+index-fields = ["col1","col2"]


更新1，index-fields格式

以及注释

Leavrth · 2021-11-15T08:24:47Z

sync-diff-inspector/sync-diff-inspector-overview.md

+# 对部分表进行特殊的配置，配置的表必须包含在 task.target-check-tables 中
+[table-configs.config1] # config1 是该配置的唯一标识 id，用于上面 task.target-configs 中
+# 目标表名称，可以使用正则来匹配多个表，但不允许存在一个表同时被多个特殊配置匹配。
+target-tables = ["schema*.test*", "test2.t2"]


更新2，target-tables 格式

以及注释

Liuxiaozhen12

LGTM

Leavrth · 2021-11-15T08:32:42Z

/verify

3pointer

LGTM

Liuxiaozhen12 · 2021-11-15T08:43:05Z

/merge

ti-chi-bot · 2021-11-15T08:43:08Z

This pull request has been accepted and is ready to merge.

Commit hash: 9e8df2f

Leavrth · 2021-11-15T08:44:51Z

/hold

Liuxiaozhen12 · 2021-11-15T09:00:08Z

/merge

ti-chi-bot · 2021-11-15T09:00:13Z

This pull request has been accepted and is ready to merge.

Commit hash: d8a755c

ti-chi-bot · 2021-11-22T09:14:09Z

In response to a cherrypick label: failed to apply #7510 on top of branch "release-5.3":

failed to git commit: exit status 1

update sync_diff_inspector settings docs

f267815

ti-chi-bot requested a review from TomShawn November 15, 2021 08:19

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2021

fix typos

bda3556

Liuxiaozhen12 added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. v5.3 This PR/issue applies to TiDB v5.3. labels Nov 15, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 15, 2021

Liuxiaozhen12 added missing-translation-status This PR does not have translation status info. type/bugfix This PR fixes a bug. labels Nov 15, 2021

Liuxiaozhen12 self-assigned this Nov 15, 2021

Leavrth commented Nov 15, 2021

View reviewed changes

Liuxiaozhen12 removed the missing-translation-status This PR does not have translation status info. label Nov 15, 2021

Update sync-diff-inspector-overview.md

5510920

Liuxiaozhen12 approved these changes Nov 15, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2021

Liuxiaozhen12 removed the request for review from TomShawn November 15, 2021 08:31

fix typos

68662f6

Leavrth added 2 commits November 15, 2021 16:34

Merge branch 'diff2_rel' of github.com:Leavrth/docs-cn into diff2_rel

433de6e

fix typos

9e8df2f

3pointer approved these changes Nov 15, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2021

change picture

f7c358b

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021

change picture

d8a755c

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021

TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2021

ti-chi-bot merged commit 0c49639 into pingcap:master Nov 15, 2021

Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Nov 16, 2021

Liuxiaozhen12 pushed a commit to Liuxiaozhen12/docs that referenced this pull request Nov 16, 2021

new translation based on pingcap/docs-cn#7510

06ee509

Liuxiaozhen12 mentioned this pull request Nov 16, 2021

update sync_diff_inspector: sync_diff_inspector v2.0 pingcap/docs#6774

Merged

14 tasks

Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.3 and removed translation/doing This PR’s assignee is translating this PR. labels Nov 16, 2021

ti-chi-bot mentioned this pull request Nov 22, 2021

update sync_diff_inspector: sync_diff_inspector v2.0 (#6774) pingcap/docs#6900

Closed

14 tasks

Leavrth deleted the diff2_rel branch November 21, 2022 01:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update sync-diff-inspector: update settings docs #7510

update sync-diff-inspector: update settings docs #7510

Leavrth commented Nov 15, 2021 •

edited

Loading

ti-chi-bot commented Nov 15, 2021 •

edited

Loading

Leavrth Nov 15, 2021

Leavrth Nov 15, 2021

Leavrth Nov 15, 2021

Leavrth Nov 15, 2021

Liuxiaozhen12 left a comment

Leavrth commented Nov 15, 2021

3pointer left a comment

Liuxiaozhen12 commented Nov 15, 2021

ti-chi-bot commented Nov 15, 2021

Leavrth commented Nov 15, 2021

Liuxiaozhen12 commented Nov 15, 2021

ti-chi-bot commented Nov 15, 2021

ti-chi-bot commented Nov 22, 2021

update sync-diff-inspector: update settings docs #7510

update sync-diff-inspector: update settings docs #7510

Conversation

Leavrth commented Nov 15, 2021 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Nov 15, 2021 • edited Loading

Leavrth Nov 15, 2021

Choose a reason for hiding this comment

Leavrth Nov 15, 2021

Choose a reason for hiding this comment

Leavrth Nov 15, 2021

Choose a reason for hiding this comment

Leavrth Nov 15, 2021

Choose a reason for hiding this comment

Liuxiaozhen12 left a comment

Choose a reason for hiding this comment

Leavrth commented Nov 15, 2021

3pointer left a comment

Choose a reason for hiding this comment

Liuxiaozhen12 commented Nov 15, 2021

ti-chi-bot commented Nov 15, 2021

Leavrth commented Nov 15, 2021

Liuxiaozhen12 commented Nov 15, 2021

ti-chi-bot commented Nov 15, 2021

ti-chi-bot commented Nov 22, 2021

Leavrth commented Nov 15, 2021 •

edited

Loading

ti-chi-bot commented Nov 15, 2021 •

edited

Loading