Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add TiDB Dashboard session docs #6711

Merged
merged 9 commits into from
Jul 23, 2021
Merged

*: Add TiDB Dashboard session docs #6711

merged 9 commits into from
Jul 23, 2021

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jul 21, 2021 •
edited by TomShawn
Loading

Signed-off-by: Breezewish me@breeswish.org

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add TiDB Dashboard docs about sessions.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions) Version number needs change
  • v5.0 (TiDB 5.0 versions) Version number needs change
  • v4.0 (TiDB 4.0 versions) Version number needs change
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@breezewish
Add TiDB Dashboard session docs
22fe4f1 
Signed-off-by: Breezewish <me@breeswish.org>
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 21, 2021 14:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2021
@breezewish
Add a final note.
2b85b49 
Signed-off-by: Breezewish <me@breeswish.org>
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels Jul 22, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 22, 2021
@TomShawn TomShawn assigned TomShawn and breezewish and unassigned TomShawn Jul 22, 2021
TomShawn
TomShawn reviewed Jul 22, 2021
View reviewed changes
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-share.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-sso.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for https://github.com/pingcap/docs-cn/pull/6711/files#r674572235

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2021
TomShawn
TomShawn reviewed Jul 22, 2021
View reviewed changes
dashboard/dashboard-session-sso.md Outdated

> **注意：**
>
> 该功能仅在 v4.0.14 或更高版本的集群中可用。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要现在 cherry-pick 到 5.1 和 5.0 吗？4.0.14 是晚于 5.1.0 和 5.0.3 的吧。5.1.0 和 5.0.3 之前的版本能使用这个功能吗？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.0.x 和 5.1.x 的文档需要另外写，例如改成 v5.1.1 可用

Copy link
Contributor

@TomShawn TomShawn Jul 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那就是 cherry-pick 到 release-5.0 和 release-5.1 暂时不合了。建议在 master 上不写版本，cp 到各个 release 分支再单独写。dev 版默认是最新开发版。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已在 #6728 中加回 4.0 的版本说明

@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 23, 2021
breezewish and others added 2 commits July 23, 2021 11:55
@breezewish @TomShawn
Update dashboard/dashboard-session-share.md
f62c08a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@breezewish @TomShawn
Update dashboard/dashboard-session-share.md
ea5a39b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@breezewish
Copy link
Member Author

@shhdgit PTAL, thanks!

shhdgit
shhdgit reviewed Jul 23, 2021
View reviewed changes
dashboard/dashboard-session-share.md

- 有效时间：分享的会话在多少时间内有效。登出当前会话不影响已分享会话的有效时间。

- 以只读权限分享：分享的会话为只读，例如不允许进行配置修改等操作。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个目前是怎么做的呀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TiDB Dashboard 侧限制的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看到了

@shhdgit
Copy link
Member

shhdgit commented Jul 23, 2021

LGTM.

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1fd4064

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit ca3d932 into pingcap:master Jul 23, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6728.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6729.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6730.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
*: Add TiDB Dashboard session docs (#6711) (#6728)
0f684c9
@TomShawn TomShawn assigned TomShawn and unassigned breezewish Jul 26, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@breezewish @3AceShowHand
*: Add TiDB Dashboard session docs (pingcap#6711)
6f1145b
@TomShawn TomShawn assigned breezewish and unassigned TomShawn Jul 28, 2021
@breezewish breezewish mentioned this pull request Jul 30, 2021
Merged
12 tasks
This was referenced Jul 30, 2021
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
*: Add TiDB Dashboard session docs (#6711) (#6730)
0b7cc8c
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2021
ti-chi-bot added a commit that referenced this pull request Sep 27, 2021
@ti-chi-bot
*: Add TiDB Dashboard session docs (#6711) (#6729)
6d7eca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@shhdgit shhdgit shhdgit left review comments

Assignees

@breezewish breezewish

Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breezewish @ti-chi-bot @shhdgit @TomShawn