Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on how to modify gcttl by tiup #6471

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Add documentation on how to modify gcttl by tiup #6471

merged 11 commits into from
Jul 8, 2021

Conversation

asddongmen
Copy link
Contributor

Add documentation on how to modify gcttl by tiup.
#1825

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2021
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 18, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 18, 2021
amyangfei
amyangfei reviewed Jul 5, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated
tiup cluster edit-config <cluster-name>
```

执行以上命令之后，进入到 vi 编辑器页面之后，修改 [server-configs](/tiup/tiup-dm-topology-reference.md#server_configs) 中 cdc 的配置，如下所示：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected.

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 5, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@asddongmen
Copy link
Contributor Author

/run-all-tests

TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/rebase

asddongmen and others added 5 commits July 8, 2021 02:47
@asddongmen @TomShawn
Update ticdc/manage-ticdc.md
b0326c0 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2021
@asddongmen @TomShawn
Update ticdc/manage-ticdc.md
6d17045 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
@asddongmen @TomShawn
Update ticdc/manage-ticdc.md
125916d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
@asddongmen @TomShawn
Update ticdc/manage-ticdc.md
e484226 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 8, 2021
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e484226

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit e67884d into master Jul 8, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6652.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6653.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
12 tasks
@TomShawn TomShawn deleted the asddongmen-gcttl-1 branch July 8, 2021 11:41
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
Add documentation on how to modify gcttl by tiup (#6471) (#6653)
4df32a5
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
Add documentation on how to modify gcttl by tiup (#6471) (#6652)
227c148
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@asddongmen @3AceShowHand
Add documentation on how to modify gcttl by tiup (pingcap#6471)
0648188
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 2, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2021
This was referenced Aug 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@TomShawn TomShawn TomShawn approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asddongmen @TomShawn @ti-chi-bot @amyangfei @Liuxiaozhen12