Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add steps to get lightning goroutine #6411

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Add steps to get lightning goroutine #6411

merged 5 commits into from
Jul 8, 2021

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jun 7, 2021 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

update FAQ from ONCALL

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 7, 2021 02:06
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2021
@TomShawn TomShawn requested review from kennytm and glorv June 7, 2021 02:07
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 7, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 7, 2021
@glorv
Copy link
Contributor

glorv commented Jun 7, 2021

LGTM

@ti-chi-bot
Copy link
Member

@kennytm: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-release-3.0 labels Jul 7, 2021
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
tidb-lightning/tidb-lightning-faq.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-faq.md Outdated

1. 如果配置文件中已经指定了 [status-port](/tidb-lightning/tidb-lightning-configuration.md#tidb-lightning-全局配置)，可以跳过此步骤。否则，需要向 TiDB Lightning 发送 USR1 信号开启 status-port。

首先通过 `ps` 等命令获取 TiDB Lightning 的进程 ID（PID），然后运行如下命令
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否给出完整的 PS 命令呢？

Suggested change
首先通过 `ps` 等命令获取 TiDB Lightning 的进程 ID（PID），然后运行如下命令
首先通过 `ps` 等命令获取 TiDB Lightning 的进程 PID，然后运行如下命令：

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps 在不同发行版的命令不一样 ps -ef、ps aux，不太好统一给一个。而且这个命令很常用，相信用户自己会的

tidb-lightning/tidb-lightning-faq.md Outdated Show resolved Hide resolved
tidb-lightning/tidb-lightning-faq.md Outdated Show resolved Hide resolved
@lance6716
Copy link
Contributor Author

CI error:

functions-and-operators/expressions-pushed-down.md: this file has manual line breaks in the following lines:

🤔

@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/rebase

lance6716 and others added 5 commits July 8, 2021 02:04
@lance6716 @TomShawn
Add steps to get lightning goroutine
d872fd7
@lance6716 @TomShawn
Update tidb-lightning-faq.md
8852be1
@lance6716 @TomShawn
Update tidb-lightning-faq.md
e4d681f
@lance6716 @TomShawn
Apply suggestions from code review
1b4ae43 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lance6716 @TomShawn
Update tidb-lightning/tidb-lightning-faq.md
82831b9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@github-actions github-actions bot force-pushed the lance6716-patch-2 branch from e7bb72d to 82831b9 Compare July 8, 2021 02:04
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 82831b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit d18686c into master Jul 8, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 19, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 19, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@lance6716 @3AceShowHand
Add steps to get lightning goroutine (pingcap#6411)
5dad8b9
@TomShawn TomShawn deleted the lance6716-patch-2 branch November 22, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@kennytm kennytm kennytm approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lance6716 @glorv @ti-chi-bot @TomShawn @kennytm @Liuxiaozhen12