Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiUP: CDC support Data dir . #6333

Merged
merged 5 commits into from
Jul 16, 2021
Merged

TiUP: CDC support Data dir . #6333

merged 5 commits into from
Jul 16, 2021

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented May 25, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

CDC support data dir for cluster version >= v4.0.13

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 25, 2021 08:11
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label May 25, 2021
@3AceShowHand 3AceShowHand requested review from amyangfei and zier-one and removed request for TomShawn May 25, 2021 08:11
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2021
@TomShawn TomShawn added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-4.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. labels May 25, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 25, 2021
@TomShawn TomShawn self-requested a review May 25, 2021 08:16
@overvenus
Copy link
Member

Could you update config-templates/complex-cdc.yml too?

rest LGTM

@TomShawn TomShawn added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label May 25, 2021
@TomShawn
Copy link
Contributor

@amyangfei Please help confirm whether this PR applies to v5.1. Thanks~

@TomShawn TomShawn assigned en-jin19 and unassigned Joyinqin Jul 8, 2021
@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 15, 2021
@TomShawn TomShawn requested a review from amyangfei July 15, 2021 08:31
@TomShawn TomShawn added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Jul 15, 2021
@TomShawn
Copy link
Contributor

/rebase

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
TomShawn
TomShawn approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 16, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01dcb19

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@ti-chi-bot ti-chi-bot merged commit 8d2d2e9 into pingcap:master Jul 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6686.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6687.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6688.

ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
TiUP: CDC support Data dir . (#6333) (#6687)
18b31af
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
TiUP: CDC support Data dir . (#6333) (#6688)
16e7775
@en-jin19 en-jin19 mentioned this pull request Jul 21, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 21, 2021
This was referenced Jul 23, 2021
Merged
Merged
Merged
3AceShowHand added a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@3AceShowHand
TiUP: CDC support Data dir . (pingcap#6333)
1776ee5
ti-chi-bot added a commit that referenced this pull request Jul 27, 2021
@ti-chi-bot
TiUP: CDC support Data dir . (#6333) (#6686)
94972ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees

@en-jin19 en-jin19

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@3AceShowHand @overvenus @TomShawn @ti-chi-bot @amyangfei @Joyinqin @en-jin19