Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document for CTE #6220

Merged
merged 14 commits into from
Jun 9, 2021
Merged

Add document for CTE #6220

merged 14 commits into from
Jun 9, 2021

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented May 7, 2021 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

Close #6216

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@wjhuang2016
init
a957283 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 7, 2021 11:27
@wjhuang2016
Copy link
Member Author

/label WIP

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label May 7, 2021
@ti-chi-bot
Copy link
Member

@wjhuang2016: The label(s) wip cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/label WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2021
@wjhuang2016
Copy link
Member Author

This PR is not ready to review now.

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label May 8, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 8, 2021
@TomShawn TomShawn added the status/WIP This PR is still working in progress. label May 8, 2021
@wjhuang2016
fix
df4b3f5 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
done
4954ccc 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
add
d16764b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@TomShawn TomShawn added the v5.1 This PR/issue applies to TiDB v5.1. label Jun 3, 2021
@TomShawn TomShawn requested a review from qiancai June 3, 2021 08:24
@TomShawn
Copy link
Contributor

TomShawn commented Jun 3, 2021 •
edited
Loading

@wjhuang2016 Please involve a technical review(s) and add it to TOC.md. Thanks~

@TomShawn TomShawn removed the status/WIP This PR is still working in progress. label Jun 3, 2021
@wjhuang2016
add to TOC
d9091c5 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
qiancai
qiancai reviewed Jun 3, 2021
View reviewed changes
wjhuang2016 and others added 3 commits June 3, 2021 19:18
@wjhuang2016 @qiancai
Update sql-statements/sql-statement-with.md
02bb349 
Co-authored-by: Grace Cai <qqzczy@126.com>
@wjhuang2016 @qiancai
Update sql-statements/sql-statement-with.md
2ca9ac2 
Co-authored-by: Grace Cai <qqzczy@126.com>
@wjhuang2016 @qiancai
Update sql-statements/sql-statement-with.md
ab74a35 
Co-authored-by: Grace Cai <qqzczy@126.com>
@wjhuang2016 wjhuang2016 mentioned this pull request Jun 3, 2021
Closed
@ti-chi-bot
Copy link
Member

@xiongjiwei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016
done
6b6ec0e 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'add_cte_doc' of github.com:wjhuang2016/docs-cn into add…
184275f 
…_cte_doc
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 4, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2021
@wjhuang2016 wjhuang2016 requested a review from TomShawn June 4, 2021 05:44
TomShawn
TomShawn reviewed Jun 4, 2021
View reviewed changes
wjhuang2016 and others added 2 commits June 4, 2021 19:24
@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-with.md
66b645d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wjhuang2016 @TomShawn
Update sql-statements/sql-statement-with.md
2922501 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
qiancai
qiancai reviewed Jun 7, 2021
View reviewed changes
sql-statements/sql-statement-with.md Outdated
## MySQL 兼容性

* 在严格模式下，当递归部分算出的数据长度超过初始部分的数据长度时，TiDB 会返回警告，而 MySQL 会返回错误。在非严格模式下，TiDB 与 MySQL 行为一致。
* 递归 CTE 所使用的数据类型由初始部分决定。初始部分的类型在某些情况（例如函数）下并不与 MySQL 完全一致。
Copy link
Collaborator

@qiancai qiancai Jun 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjhuang2016 关于 “初始部分的类型在某些情况（例如函数）下并不与 MySQL 完全一致。”，这里请问可以再具体说下吗“某些情况”是哪些情况吗？只有函数是我们已知的不一致的情况吗？这种不一致是否会对计算结果产生影响呢？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些情况并不能列举完，会对计算结果有影响。

Copy link
Collaborator

@qiancai qiancai Jun 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不一致的情况可以再提供一个例子吗？当无法直接说明是哪些情况的时候，能够多给几个例子对用户的帮助也是极大的。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

暂时没想到

@wjhuang2016 @qiancai
Update sql-statements/sql-statement-with.md
c29958d 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c29958d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2021
@qiancai
Copy link
Collaborator

qiancai commented Jun 9, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 279bef9 into pingcap:master Jun 9, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jun 10, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@TomShawn TomShawn TomShawn approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.1 This PR/issue applies to TiDB v5.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add document for CTE
6 participants
@wjhuang2016 @ti-chi-bot @TomShawn @qiancai @Liuxiaozhen12 @xiongjiwei