Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optimal parameter configrations. #5303

Merged
merged 30 commits into from
Jan 22, 2021
Merged

add optimal parameter configrations. #5303

merged 30 commits into from
Jan 22, 2021

Conversation

pepezzzz
Copy link
Contributor

@pepezzzz pepezzzz commented Jan 13, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

add tuned profile, udev script and cpu governor systemd service configrations

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

ethercflow
ethercflow reviewed Jan 13, 2021
View reviewed changes
check-before-deployment.md Outdated
transparent_hugepages=never

[disk]
devices_udev_regex=(ID_SERIAL=36d0946606d79f90025f3e09a0c1fc035)|(ID_SERIAL=36d0946606d79f90025f3e09a0c1f9e81)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有个疑问，如果用户因磁盘损坏等问题换盘，tuned 的行为是怎样的？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 ID_SERIAL 的话，需要重新编辑，因为正则匹配不上了。之前 ORACLE 用 udev 规则写磁盘阵列上的 LUN 的权限时，有时候会用 ID_VENDOR 把厂商 ID 给绑定。在我们的服务器内部磁盘的场景中，可能没有办法用上这种方法。

@TomShawn TomShawn added needs-cherry-pick-3.1 size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Jan 13, 2021
ethercflow
ethercflow approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@ethercflow ethercflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@ethercflow, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

kissmydb
kissmydb approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2021
pepezzzz and others added 4 commits January 13, 2021 13:25
@pepezzzz @kissmydb
Update check-before-deployment.md
a296cd9 
Co-authored-by: kissmydb <likun@pingcap.com>
@pepezzzz @kissmydb
Update check-before-deployment.md
70f465d 
Co-authored-by: kissmydb <likun@pingcap.com>
@pepezzzz @kissmydb
Update check-before-deployment.md
6757e6d 
Co-authored-by: kissmydb <likun@pingcap.com>
@pepezzzz
Update check-before-deployment.md
e269dd0
TomShawn
TomShawn reviewed Jan 13, 2021
View reviewed changes
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
check-before-deployment.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Jan 13, 2021
@ti-srebot
Copy link
Contributor

@pepezzzz, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@pepezzzz, please update your pull request.

@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 22, 2021
@TomShawn TomShawn added size/large Changes of a large size. and removed size/medium Changes of a medium size. status/require-change Needs the author to address comments. labels Jan 22, 2021
@TomShawn TomShawn merged commit acd25ed into pingcap:master Jan 22, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 22, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#5303 to release-2.1
1cd37b6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 22, 2021
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #5371

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 22, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#5303 to release-3.0
9539df2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 22, 2021
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #5372

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 22, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#5303 to release-3.1
858b6b3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 22, 2021
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #5373

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 22, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#5303 to release-4.0
c9595d6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 22, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5374

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 22, 2021
@pepezzzz @ti-srebot
cherry pick pingcap#5303 to release-5.0
d3a8ac3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 22, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5375

TomShawn added a commit that referenced this pull request Jan 22, 2021
@ti-srebot @pepezzzz @TomShawn
add optimal parameter configrations. (#5303) (#5374)
bfba7ee 
* cherry pick #5303 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update check-before-deployment.md

Co-authored-by: pepezzzz <35323945+pepezzzz@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Jan 22, 2021
@ti-srebot @pepezzzz @TomShawn
add optimal parameter configrations. (#5303) (#5375)
4e314a9 
* cherry pick #5303 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update check-before-deployment.md

Co-authored-by: pepezzzz <35323945+pepezzzz@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@CharLotteiu CharLotteiu mentioned this pull request Jan 26, 2021
Merged
10 tasks
@CharLotteiu CharLotteiu added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 26, 2021
This was referenced Feb 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kissmydb kissmydb kissmydb approved these changes

@ethercflow ethercflow ethercflow approved these changes

@TomShawn TomShawn TomShawn approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@CharLotteiu CharLotteiu

Labels
size/large Changes of a large size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pepezzzz @ti-srebot @kissmydb @ethercflow @TomShawn @CharLotteiu