Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multi-data-centers-in-one-city-deployment.md #4596

Merged
merged 7 commits into from
Sep 30, 2020
Merged

Update multi-data-centers-in-one-city-deployment.md #4596

merged 7 commits into from
Sep 30, 2020

Conversation

King-Dylan
Copy link
Contributor

@King-Dylan King-Dylan commented Sep 25, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@King-Dylan King-Dylan marked this pull request as draft September 25, 2020 04:47
@King-Dylan King-Dylan marked this pull request as ready for review September 25, 2020 04:48
@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Sep 25, 2020
King-Dylan and others added 2 commits September 25, 2020 16:06
@King-Dylan @TomShawn
Update multi-data-centers-in-one-city-deployment.md
9d8c1ba 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@King-Dylan
Merge branch 'release-4.0' into patch-2
b2da5b4
@ti-srebot
Copy link
Contributor

@disksing,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

lucklove
lucklove approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
TomShawn
TomShawn previously approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2020
ti-srebot
ti-srebot previously approved these changes Sep 27, 2020
View reviewed changes
@TomShawn TomShawn dismissed stale reviews from ti-srebot and themself September 27, 2020 05:40

needs update

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Sep 27, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @disksing, @lucklove, @ti-srebot, PTAL.

TomShawn
TomShawn approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 01cb5cd into pingcap:release-4.0 Sep 30, 2020
@TomShawn TomShawn mentioned this pull request Sep 30, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented Oct 6, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Oct 6, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Oct 6, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Oct 6, 2020
@Joyinqin Joyinqin mentioned this pull request Oct 6, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Oct 10, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@disksing disksing disksing approved these changes

@lucklove lucklove lucklove approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@King-Dylan @ti-srebot @Joyinqin @lucklove @disksing @TomShawn