Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add redact-info-log #4594

Merged
merged 3 commits into from
Sep 27, 2020
Merged

config: add redact-info-log #4594

merged 3 commits into from
Sep 27, 2020

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Sep 25, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Add redact-info-log, which removes all user data in log.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn requested a review from BusyJay September 25, 2020 02:47
@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Sep 25, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-srebot
Copy link
Contributor

@BusyJay, PTAL.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
TomShawn
TomShawn approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 27, 2020
@TomShawn TomShawn merged commit 36e256c into pingcap:master Sep 27, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 27, 2020
@skyzh @ti-srebot
cherry pick pingcap#4594 to release-4.0
5538397 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 27, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4612

TomShawn pushed a commit that referenced this pull request Sep 27, 2020
@ti-srebot @skyzh
cherry pick #4594 to release-4.0 (#4612)
bfca239 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Alex Chi <iskyzh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

@TomShawn TomShawn TomShawn approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@skyzh skyzh

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skyzh @CLAassistant @ti-srebot @BusyJay @TomShawn