Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transactions: improve clarity of transactions #4577

Merged
merged 7 commits into from
Sep 29, 2020
Merged

transactions: improve clarity of transactions #4577

merged 7 commits into from
Sep 29, 2020

Conversation

ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

This improves the clarity of when you would use optimistic transactions, autocommit, atomic statement rollback etc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-4.0 labels Sep 24, 2020
@ireneontheway ireneontheway marked this pull request as ready for review September 24, 2020 06:49
jackysp
jackysp reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2020
lilin90
lilin90 reviewed Sep 27, 2020
View reviewed changes
optimistic-transaction.md Outdated Show resolved Hide resolved
optimistic-transaction.md Show resolved Hide resolved
pessimistic-transaction.md Outdated Show resolved Hide resolved
pessimistic-transaction.md Outdated Show resolved Hide resolved
pessimistic-transaction.md Outdated Show resolved Hide resolved
transaction-overview.md Outdated Show resolved Hide resolved
transaction-overview.md Outdated Show resolved Hide resolved
transaction-overview.md Outdated Show resolved Hide resolved
transaction-overview.md Outdated Show resolved Hide resolved
transaction-overview.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added status/require-change Needs the author to address comments. size/medium Changes of a medium size. labels Sep 27, 2020
@ireneontheway @lilin90
Apply suggestions from code review
1aaa2ee 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
This was referenced Sep 29, 2020
Closed
Merged
lilin90
lilin90 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 29, 2020
@lilin90
Copy link
Member

lilin90 commented Sep 29, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2020
@lilin90 lilin90 removed the status/require-change Needs the author to address comments. label Sep 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit bdb0238 into pingcap:master Sep 29, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 29, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#4577 to release-4.0
3ab6c92 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 29, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4628

@ti-srebot ti-srebot mentioned this pull request Sep 29, 2020
Merged
9 tasks
lilin90 pushed a commit that referenced this pull request Sep 29, 2020
@ti-srebot @ireneontheway
cherry pick #4577 to release-4.0 (#4628)
a3762f4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ireneontheway @lilin90 @ti-srebot @jackysp