Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how to connect TiDB by MySQL Client and the limitations of the global indexes #19345

Merged
merged 11 commits into from
Dec 25, 2024
Merged

Update how to connect TiDB by MySQL Client and the limitations of the global indexes #19345

merged 11 commits into from
Dec 25, 2024

Conversation

Frank945946
Copy link
Collaborator

@Frank945946 Frank945946 commented Dec 22, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update how to connect TiDB by MySQL Client and the limits of the global indexes

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/develop This PR relates to the area of TiDB App development. labels Dec 22, 2024
@Frank945946 Frank945946 changed the title Update how to connect TiDB by MySQL Client Update how to connect TiDB by MySQL Client and the limits of the global indexes Dec 23, 2024
@Frank945946 Frank945946 changed the title Update how to connect TiDB by MySQL Client and the limits of the global indexes Update how to connect TiDB by MySQL Client and the limitations of the global indexes Dec 23, 2024
@hfxsd hfxsd self-assigned this Dec 23, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 23, 2024
@hfxsd hfxsd mentioned this pull request Dec 23, 2024
Merged
17 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 23, 2024
hfxsd
hfxsd reviewed Dec 23, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Dec 24, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from lilin90 December 24, 2024 02:55
lilin90
lilin90 reviewed Dec 25, 2024
View reviewed changes
develop/dev-guide-connect-to-tidb.md Outdated Show resolved Hide resolved
develop/dev-guide-connect-to-tidb.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
@hfxsd @lilin90
Apply suggestions from code review
83d6d9e 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Icemap
Icemap approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@Icemap Icemap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and don't forget the English edition.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 25, 2024
hfxsd
hfxsd reviewed Dec 25, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
@Frank945946 @hfxsd
Update partitioned-table.md
3fe245d 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Defined2014
Defined2014 reviewed Dec 25, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
hfxsd and others added 2 commits December 25, 2024 14:39
@hfxsd
Update develop/dev-guide-connect-to-tidb.md
41b7076
@hfxsd @Defined2014
Update partitioned-table.md
5fc7ebb 
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
lilin90
lilin90 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-25 06:02:42.425152961 +0000 UTC m=+1627952.513955503: ☑️ agreed by Icemap.
  • 2024-12-25 08:03:51.070751478 +0000 UTC m=+1635221.159554018: ☑️ agreed by lilin90.

@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 25, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 25, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 23ad700 into pingcap:master Dec 25, 2024
7 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19381.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 25, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 25, 2024
@ti-chi-bot
Update how to connect TiDB by MySQL Client and the limitations of the…
89c082b 
… global indexes (#19345) (#19381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 left review comments

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 lilin90 approved these changes

@Icemap Icemap Icemap approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Frank945946 @hfxsd @ti-chi-bot @Defined2014 @Icemap @lilin90