Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multirocks related config update #13991

Merged
merged 6 commits into from
May 18, 2023
Merged

multirocks related config update #13991

merged 6 commits into from
May 18, 2023

Conversation

tonyxuqqi
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@tonyxuqqi
multirocks
747ebe0 
Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2023
@tonyxuqqi tonyxuqqi requested review from tabokie and Oreoxmt May 16, 2023 23:18
@tonyxuqqi tonyxuqqi mentioned this pull request May 16, 2023
Merged
17 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. for-release This PR relates to a TiDB release but does not have a tracked feature. v7.1 This PR/issue applies to TiDB v7.1. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels May 17, 2023
hfxsd
hfxsd reviewed May 17, 2023
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
configure-load-base-split.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-assigned this May 17, 2023
hfxsd and others added 2 commits May 18, 2023 09:43
@hfxsd
Apply suggestions from code review
e43367e
@Oreoxmt
add release notes and links
9379acf 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2023
hfxsd
hfxsd reviewed May 18, 2023
View reviewed changes
releases/release-7.1.0.md Outdated Show resolved Hide resolved
hfxsd
hfxsd approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@Oreoxmt @hfxsd
Apply suggestions from code review
e1999e2 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented May 18, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6dea82c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit b664e9b into pingcap:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@tabokie tabokie tabokie approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
for-release This PR relates to a TiDB release but does not have a tracked feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyxuqqi @Oreoxmt @tabokie @hfxsd