Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dist task framework introduction doc #13705

Merged
merged 49 commits into from
May 17, 2023
Merged

Add dist task framework introduction doc #13705

merged 49 commits into from
May 17, 2023

Conversation

Benjamin2037
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

This pr is used to add introduction doc for backend task distriubted parallel execution framework document.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2023
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. v7.1 This PR/issue applies to TiDB v7.1. labels Apr 17, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 17, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang April 17, 2023 01:24
@ran-huang
restructure; cleanup; fix linter
f967f2d 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2023
@ran-huang ran-huang requested a review from tangenta April 18, 2023 03:52
ran-huang
ran-huang reviewed Apr 18, 2023
View reviewed changes
ran-huang and others added 4 commits May 16, 2023 10:59
@ran-huang @qiancai
Apply suggestions from code review
d149019 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang
Update tidb-distributed-execution-framework.md
2d3f78a
@ran-huang @qiancai
Update TOC.md
cc3d104 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang @qiancai
Apply suggestions from code review
cace623 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2023
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 16, 2023
@ran-huang ran-huang mentioned this pull request May 16, 2023
Merged
16 tasks
@Benjamin2037
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@Benjamin2037
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

@Benjamin2037: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

qiancai
qiancai approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2023
@ran-huang
add a link
a47da68 
Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a47da68

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit cac3b2e into master May 17, 2023
@ran-huang ran-huang deleted the add_dist_task_framework_v7.1 branch May 17, 2023 03:08
@ran-huang ran-huang mentioned this pull request May 17, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@ran-huang ran-huang ran-huang approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@ran-huang ran-huang

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjamin2037 @ti-chi-bot @ran-huang @tangenta @qiancai @Oreoxmt