Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add variable tidb_enable_inl_join_inner_multi_pattern #13451

Merged
merged 4 commits into from
Mar 20, 2023
Merged

planner: add variable tidb_enable_inl_join_inner_multi_pattern #13451

merged 4 commits into from
Mar 20, 2023

Conversation

chrysan
Copy link
Contributor

@chrysan chrysan commented Mar 16, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a new variable tidb_enable_inl_join_inner_multi_pattern to control whether the inner table of Index Join supports Selection or Projection operators.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@chrysan chrysan requested review from qw4990 and Oreoxmt March 16, 2023 15:01
@Oreoxmt Oreoxmt self-assigned this Mar 16, 2023
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 16, 2023
@Oreoxmt Oreoxmt removed the request for review from shichun-0415 March 16, 2023 15:04
@Oreoxmt Oreoxmt added v7.0 type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Mar 16, 2023
@qw4990 @Oreoxmt
Update system-variables.md
ff70fe5 
Co-authored-by: Aolin <aolinz@outlook.com>
qw4990
qw4990 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oreoxmt
Oreoxmt reviewed Mar 17, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt mentioned this pull request Mar 17, 2023
Merged
15 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 17, 2023
@Oreoxmt Oreoxmt self-requested a review March 17, 2023 02:50
Oreoxmt
Oreoxmt approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang March 17, 2023 02:50
@Oreoxmt Oreoxmt added the area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. label Mar 17, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 17, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2023
@chrysan @Oreoxmt
Update system-variables.md
b1524e6 
Co-authored-by: Aolin <aolinz@outlook.com>
ran-huang
ran-huang reviewed Mar 17, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
ran-huang
ran-huang approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Oreoxmt @ran-huang
Apply suggestions from code review
27614d2 
Co-authored-by: Ran <huangran.alex@gmail.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 17, 2023

/remove-status LGT2
/status LGT3

@ti-chi-bot ti-chi-bot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 17, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 20, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27614d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2023
@ti-chi-bot ti-chi-bot merged commit 33dde3d into pingcap:master Mar 20, 2023
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Apr 13, 2023
This was referenced Apr 13, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13699.

ti-chi-bot added a commit that referenced this pull request Apr 14, 2023
@ti-chi-bot
planner: add variable tidb_enable_inl_join_inner_multi_pattern (#13451)…
136fea3 
… (#13699)
@ran-huang ran-huang added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13716.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 19, 2023
Merged
15 tasks
ti-chi-bot added a commit that referenced this pull request Apr 21, 2023
@ti-chi-bot
planner: add variable tidb_enable_inl_join_inner_multi_pattern (#13451)…
9063211 
… (#13716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@ran-huang ran-huang ran-huang approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrysan @ti-chi-bot @Oreoxmt @qw4990 @ran-huang