Skip to content

Add compression to TiCDC Kafka sink config #12198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2022
Merged

Add compression to TiCDC Kafka sink config #12198

merged 2 commits into from
Dec 28, 2022

Conversation

overvenus
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add compression to TiCDC Kafka sink config.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@overvenus overvenus added the area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. label Dec 5, 2022
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 5, 2022 04:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2022
@shichun-0415 shichun-0415 self-assigned this Dec 5, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Dec 5, 2022
shichun-0415
shichun-0415 reviewed Dec 5, 2022
View reviewed changes
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 28, 2022
@shichun-0415
Copy link
Contributor

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 28, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef01256

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@ti-chi-bot ti-chi-bot merged commit dc40d46 into master Dec 28, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 28, 2022
@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#12198
07d4aaf 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.1: #12462.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12464.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 28, 2022
@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#12198
0770785 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
@shichun-0415 shichun-0415 deleted the overvenus-patch-2 branch December 28, 2022 08:49
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #12465.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 28, 2022
@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#12198
413c3b2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 28, 2022
@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#12198
75a92c9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12466.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12467.

ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12456)
f110655
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12462)
b0fc27b
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12457)
cc9f4c1
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12458)
b084108
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12460)
dee7b54
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12459)
3c845e4
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12464)
2a3e5a3
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12461)
3949ae3
shichun-0415 added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot @overvenus @shichun-0415
Add compression to TiCDC Kafka sink config (#12198) (#12465)
007e93b 
* This is an automated cherry-pick of #12198

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* update

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: shichun-0415 <lishichun@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12467)
3c1bcbb
ti-chi-bot added a commit that referenced this pull request Jan 2, 2023
@ti-chi-bot
Add compression to TiCDC Kafka sink config (#12198) (#12466)
908bbd3
@shichun-0415 shichun-0415 mentioned this pull request Jan 17, 2023
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

+1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@shichun-0415 shichun-0415

Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-chi-bot @shichun-0415 @asddongmen