Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables.md: update tidb_ddl_enable_fast_reorg #12111

Merged
merged 5 commits into from
Dec 2, 2022
Merged

system-variables.md: update tidb_ddl_enable_fast_reorg #12111

merged 5 commits into from
Dec 2, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 24, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 24, 2022 06:34
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2022
@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for TomShawn November 24, 2022 06:36
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Nov 24, 2022
@Oreoxmt Oreoxmt self-assigned this Nov 24, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 24, 2022
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. v6.5 This PR/issue applies to TiDB v6.5. labels Nov 24, 2022
Oreoxmt
Oreoxmt approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2022
@Oreoxmt Oreoxmt removed the missing-translation-status This PR does not have translation status info. label Nov 24, 2022
@Oreoxmt Oreoxmt requested a review from TomShawn November 24, 2022 06:53
@tangenta @Oreoxmt
Update system-variables.md
a8147b0 
Co-authored-by: Aolin <aolinz@outlook.com>
Oreoxmt
Oreoxmt reviewed Nov 24, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@tangenta @Oreoxmt
Update system-variables.md
aa53448 
Co-authored-by: Aolin <aolinz@outlook.com>
Benjamin2037
Benjamin2037 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oreoxmt
Oreoxmt approved these changes Nov 28, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 28, 2022
@Oreoxmt Oreoxmt mentioned this pull request Nov 28, 2022
Merged
15 tasks
tangenta and others added 2 commits November 28, 2022 12:06
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2022
Oreoxmt
Oreoxmt approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b4e1427

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022
@ti-chi-bot ti-chi-bot merged commit a68faf0 into pingcap:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@TomShawn TomShawn TomShawn approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangenta @ti-chi-bot @Oreoxmt @Benjamin2037 @TomShawn