Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Change compatibility description for add index acceleration&PiTR #11877

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

Benjamin2037
Copy link
Contributor

@Benjamin2037 Benjamin2037 commented Nov 3, 2022

What is changed, added or deleted? (Required)

Add more description to make compatibility issue more clean between add index acceleration and PiTR. Let user can clearly know what will happen.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 3, 2022 09:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2022
@Benjamin2037 Benjamin2037 changed the title Change compatibility description for add index acceleration&PiTR *: Change compatibility description for add index acceleration&PiTR Nov 3, 2022
@Benjamin2037 Benjamin2037 requested a review from tangenta November 3, 2022 09:56
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Nov 3, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 3, 2022
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt self-assigned this Nov 3, 2022
@Oreoxmt Oreoxmt self-requested a review November 3, 2022 10:12
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@Benjamin2037
Copy link
Contributor Author

Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2022
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 4, 2022
@Oreoxmt Oreoxmt requested review from shichun-0415 and removed request for TomShawn November 4, 2022 03:25
@Benjamin2037
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Benjamin2037: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8ab8d6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@ti-chi-bot ti-chi-bot merged commit 330e9a7 into master Nov 4, 2022
@Oreoxmt Oreoxmt deleted the add_index_accelerate_doc_chg branch November 4, 2022 09:20
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11901.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants