Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version mark #11186

Merged
merged 2 commits into from
Sep 2, 2022
Merged

fix version mark #11186

merged 2 commits into from
Sep 2, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Sep 2, 2022

What is changed, added or deleted? (Required)

Fix the format of version mark

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Sep 2, 2022
@Oreoxmt Oreoxmt requested a review from TomShawn September 2, 2022 09:49
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Oreoxmt Oreoxmt added the translation/no-need No need to translate this PR. label Sep 2, 2022
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2022
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/LGT1 Indicates that a PR has LGTM 1. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Sep 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dac6865

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2022
@ti-chi-bot ti-chi-bot merged commit ff7afa7 into pingcap:master Sep 2, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2022
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11187.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2022
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11188.

ti-chi-bot added a commit that referenced this pull request Sep 2, 2022
ti-chi-bot added a commit that referenced this pull request Sep 2, 2022
@Oreoxmt Oreoxmt deleted the fix/version-mark branch October 19, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants