Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: remove pulsar #11112

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Aug 26, 2022

Signed-off-by: hi-rustin rustin.liu@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

remove pulsar, we removed it from the code.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Rustin170506 Rustin170506 requested a review from zier-one August 26, 2022 09:31
@ti-chi-bot ti-chi-bot requested a review from TomShawn August 26, 2022 09:31
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2022
@Rustin170506 Rustin170506 reopened this Sep 6, 2022
@shichun-0415
Copy link
Contributor

@hi-rustin @leoppro Maybe we should also mention the removal of the experimental feature in 6.3 release notes.

@shichun-0415 shichun-0415 self-assigned this Sep 18, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. v6.3 This PR/issue applies to TiDB v6.3. and removed missing-translation-status This PR does not have translation status info. labels Sep 18, 2022
@Rustin170506
Copy link
Member Author

@hi-rustin @leoppro Maybe we should also mention the removal of the experimental feature in 6.3 release notes.

Yes. I think we need to add it.

@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 22, 2022
@shichun-0415 shichun-0415 requested review from Oreoxmt and removed request for TomShawn September 23, 2022 03:03
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/ticdc-faq.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2022
Rustin170506 and others added 2 commits September 23, 2022 11:07
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@Oreoxmt Oreoxmt self-requested a review September 23, 2022 03:56
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ca8861

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2022
@ti-chi-bot ti-chi-bot merged commit ceb3b50 into pingcap:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants