Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add fast mode #10560

Merged
merged 22 commits into from
Aug 1, 2022
Merged

sql: add fast mode #10560

merged 22 commits into from
Aug 1, 2022

Conversation

hongyunyan
Copy link
Contributor

@hongyunyan hongyunyan commented Jul 18, 2022 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 18, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 July 18, 2022 10:31
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2022
@hongyunyan
Copy link
Contributor Author

cc @flowbehappy

@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. v6.2 This PR/issue applies to TiDB v6.2. and removed missing-translation-status This PR does not have translation status info. labels Jul 18, 2022
@shichun-0415 shichun-0415 requested review from hfxsd and flowbehappy and removed request for shichun-0415 July 18, 2022 10:35
@shichun-0415 shichun-0415 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
@shichun-0415 shichun-0415 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
hfxsd
hfxsd reviewed Jul 21, 2022
View reviewed changes
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 25, 2022
@TomShawn
Copy link
Contributor

/verify

hfxsd
hfxsd approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
ran-huang
ran-huang reviewed Jul 27, 2022
View reviewed changes
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
develop/dev-guide-read-in-fast-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-set-tiflash-mode.md Outdated Show resolved Hide resolved
@hfxsd @ran-huang
Apply suggestions from code review
86081a3 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
hongyunyan and others added 2 commits July 29, 2022 10:26
@hongyunyan @hfxsd
Update develop/dev-guide-read-in-fast-mode.md
f955d44 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hongyunyan @ran-huang
Update develop/dev-guide-read-in-fast-mode.md
b79e41b 
Co-authored-by: Ran <huangran.alex@gmail.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Aug 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 070448e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@ti-chi-bot ti-chi-bot merged commit 3a2e640 into pingcap:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy left review comments

@hfxsd hfxsd hfxsd approved these changes

@ran-huang ran-huang ran-huang approved these changes

@shichun-0415 shichun-0415 shichun-0415 left review comments

Assignees

@hfxsd hfxsd

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hongyunyan @ti-chi-bot @CLAassistant @TomShawn @hfxsd @flowbehappy @ran-huang @shichun-0415