Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add a configuration to adjust safe mode duration when dm task abnormal reboot #10555

Merged
merged 7 commits into from
Sep 15, 2022
Merged

dm: add a configuration to adjust safe mode duration when dm task abnormal reboot #10555

merged 7 commits into from
Sep 15, 2022

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jul 18, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 July 18, 2022 07:21
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. area/dm v6.2 This PR/issue applies to TiDB v6.2. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Jul 18, 2022
@shichun-0415 shichun-0415 removed their request for review July 18, 2022 08:11
ran-huang
ran-huang approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@okJiang @ran-huang
Update dm/task-configuration-file-full.md
edafe5c 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ran-huang @sunzhaoyang
Update dm/task-configuration-file-full.md
52564d3 
Co-authored-by: sunzy <sunzy2@gmail.com>
@ran-huang ran-huang requested a review from hfxsd July 19, 2022 06:06
hfxsd
hfxsd approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@ran-huang @hfxsd
Update dm/task-configuration-file-full.md
37fba10 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@shichun-0415 shichun-0415 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
sunzhaoyang
sunzhaoyang approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
ran-huang
ran-huang reviewed Jul 20, 2022
View reviewed changes
dm/dm-safe-mode.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@ran-huang ran-huang added for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed v6.2 This PR/issue applies to TiDB v6.2. labels Jul 21, 2022
@ran-huang ran-huang added v6.3 This PR/issue applies to TiDB v6.3. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Sep 15, 2022
@okJiang @ran-huang
Update dm/dm-safe-mode.md
4e88080 
Co-authored-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2022
@ran-huang ran-huang requested review from Oreoxmt and removed request for shichun-0415 September 15, 2022 06:15
Oreoxmt
Oreoxmt approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dm/task-configuration-file-full.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Sep 15, 2022
View reviewed changes
dm/dm-safe-mode.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

okJiang and others added 2 commits September 15, 2022 15:04
@okJiang @Oreoxmt
Update dm/task-configuration-file-full.md
e8c02ab 
Co-authored-by: Aolin <aolinz@outlook.com>
@okJiang @Oreoxmt
Update dm/dm-safe-mode.md
0189cfb 
Co-authored-by: Aolin <aolinz@outlook.com>
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0189cfb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2022
@ti-chi-bot ti-chi-bot merged commit cb23215 into pingcap:master Sep 15, 2022
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@shichun-0415 shichun-0415 shichun-0415 left review comments

@sunzhaoyang sunzhaoyang sunzhaoyang approved these changes

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

Assignees

@ran-huang ran-huang

Labels
area/dm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.3 This PR/issue applies to TiDB v6.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@okJiang @ti-chi-bot @ran-huang @sunzhaoyang @hfxsd @Oreoxmt @shichun-0415 @Frank945946