Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wpf: Fix GDI handle issues when using resized Bitmaps #2552

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Wpf: Fix GDI handle issues when using resized Bitmaps #2552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Eto.Wpf/Drawing/BitmapHandler.cs
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,14 @@ public void Create(Image image, int width, int height, ImageInterpolation interp
drawingContext.DrawDrawing(group);

var resizedImage = new swmi.RenderTargetBitmap(width, height, source.DpiX, source.DpiY, swm.PixelFormats.Default);
resizedImage.RenderWithCollect(drawingVisual);
Control = resizedImage;
resizedImage.Render(drawingVisual);

// Don't use RenderTargetBitmap directly, it can run out of GDI handles when you have many bitmaps.
var writable = new swmi.WriteableBitmap(resizedImage);
Control = writable;

// collect immediately to get rid of the handle use
GC.Collect(GC.MaxGeneration, GCCollectionMode.Forced, false);
}

protected override void Initialize()
Expand Down
Loading