CockroachDB Support

[gnat]

Work in progress for #607

[lgtm-com]

This pull request introduces 9 alerts when merging 3f050fc into ed93feb - view on LGTM.com

new alerts:

• 5 for Unused import
• 2 for Wrong number of arguments in a call
• 2 for Wrong number of arguments in a class instantiation

[lgtm-com]

This pull request introduces 9 alerts when merging 18e27c1 into ed93feb - view on LGTM.com

new alerts:

• 5 for Unused import
• 2 for Wrong number of arguments in a call
• 2 for Wrong number of arguments in a class instantiation

[lgtm-com]

This pull request introduces 7 alerts when merging 177ed05 into ed93feb - view on LGTM.com

new alerts:

• 7 for Unused import

[lgtm-com]

This pull request introduces 7 alerts when merging 22b88ad into ed93feb - view on LGTM.com

new alerts:

• 6 for Unused import
• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 7 alerts when merging c9af100 into ed93feb - view on LGTM.com

new alerts:

• 6 for Unused import
• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 7 alerts when merging 62be177 into ed93feb - view on LGTM.com

new alerts:

• 6 for Unused import
• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 1 alert when merging 9f0c99b into 4f3c1f3 - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 1 alert when merging a8bc2f2 into 4f3c1f3 - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[dantownsend]

What's the recommended way of getting a CockroachDB cluster with reasonable performance running locally?

I remember @sinisaos mentioned using something like this:

cockroach start-single-node --insecure --store=type=mem,size=2GiB

As you suggested, 2GB makes it quite snappy.

Maybe we can add something to contributing/index.rst to help devs get a decent setup for running unit tests.

[lgtm-com]

This pull request introduces 1 alert when merging c304fba into 45dbb8b - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 1 alert when merging 346aa55 into 45dbb8b - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 1 alert when merging ebe06e7 into 45dbb8b - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[codecov-commenter]

Codecov Report

Merging #608 (ae0d589) into master (45dbb8b) will increase coverage by 0.05%.
The diff coverage is 89.88%.

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   91.22%   91.27%   +0.05%     
==========================================
  Files          98       99       +1     
  Lines        7052     7209     +157     
==========================================
+ Hits         6433     6580     +147     
- Misses        619      629      +10     

Impacted Files	Coverage Δ
piccolo/columns/defaults/time.py	70.83% <42.85%> (-4.78%)	⬇️
piccolo/columns/defaults/timestamp.py	94.54% <71.42%> (-3.38%)	⬇️
piccolo/engine/cockroach.py	78.04% <78.04%> (ø)
piccolo/columns/defaults/date.py	80.00% <83.33%> (+0.51%)	⬆️
piccolo/query/mixins.py	94.83% <85.71%> (-0.65%)	⬇️
piccolo/apps/asgi/commands/new.py	73.43% <100.00%> (ø)
piccolo/apps/migrations/auto/migration_manager.py	94.64% <100.00%> (+0.05%)	⬆️
piccolo/apps/schema/commands/generate.py	89.96% <100.00%> (+3.19%)	⬆️
piccolo/columns/base.py	94.67% <100.00%> (ø)
piccolo/columns/column_types.py	88.04% <100.00%> (+0.08%)	⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[lgtm-com]

This pull request introduces 1 alert when merging 2354a40 into 45dbb8b - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[lgtm-com]

This pull request introduces 1 alert when merging ae0d589 into 45dbb8b - view on LGTM.com

new alerts:

• 1 for First argument to super() is not enclosing class

[dantownsend]

@gnat OK, let's get this merged in. Sorry it has taken me so long.