Cockroach ALTER COLUMN TYPE moved outside of transaction until #49351…

… is solved.
piccolo-orm · Sep 1, 2022 · 62be177 · 62be177
1 parent c9af100
commit 62be177
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/piccolo/apps/migrations/auto/migration_manager.py b/piccolo/apps/migrations/auto/migration_manager.py
@@ -788,4 +788,10 @@ async def run(self, backwards=False):
             await self._run_drop_columns(backwards=backwards)
             await self._run_drop_tables(backwards=backwards)
             await self._run_rename_columns(backwards=backwards)
+            # CockroachDB: https://github.com/cockroachdb/cockroach/issues/49351 "ALTER COLUMN TYPE is not supported inside a transaction"
+            # We can move _run_alter_columns() for cockroach back here when the issue is resolved.
+            if engine.engine_type != "cockroach":
+                await self._run_alter_columns(backwards=backwards)
+
+        if engine.engine_type == "cockroach":
             await self._run_alter_columns(backwards=backwards)