Skip to content

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:
It does 3 things:

  1. While thinking about Total Queries Graph - Summary hover screen #3600 I noticed that the tooltip in the total query graph was floating above the cursor position and mostly hiding the bars. In the client activity this was a bit better, because the tooltip was below the cursor position but it would still follow the cursor in y direction which could also hiding bars. This PR fixes the tooltip to the x-axis independently of the y-postion of the cursor.

Peek 2025-09-10 10-10

  1. The client graph tooltip did hide all elements which had no queries in the selected time slot, the query graph did not. This is fixed now
Screenshot from 2025-09-10 10-10-58
  1. Fixed the calculation of the tooltip percentage (this was most obvious in low-query time slots, see the screenshot above). The issue was that the total sum of the time slot was calculated by the values of tooltipLabel.parsed._stacks.y, but it did not only contained key/values for the actual data but some meta-data. This is fixed by only sum the values for keys not starting with _

Fixes #3600


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team as a code owner September 10, 2025 09:05
@yubiuser yubiuser linked an issue Sep 10, 2025 that may be closed by this pull request
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser yubiuser merged commit 94e8e90 into development Oct 4, 2025
11 checks passed
@yubiuser yubiuser deleted the tooltip branch October 4, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Total Queries Graph - Summary hover screen

2 participants