Validate extension name in phylum extension new#529
Merged
Conversation
Since both `Extension::install` and `Extension::load` already validate the extension regex through `Extension::try_from`, it's not necessary to check against the regex there. The only other location, `Extension::uninstall`, requires installing the extension first, making it unnecessary to add a dedicated check there.
Since `phylum extension new` is likely the most common way users will create new extensions, it should not be possible to creat invalid extensions with it. This patch validates the extension name during creation, refusing to create one with an invalid name. Closes #515.
andreaphylum
previously approved these changes
Jul 7, 2022
andreaphylum
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
phylum extension newis likely the most common way users willcreate new extensions, it should not be possible to creat invalid
extensions with it.
This patch validates the extension name during creation, refusing to
create one with an invalid name.
Closes #515.