Skip to content

Invoke GrumPHP executable using the PHP binary so it respects the PHP version Composer was invoked with. #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2.x
Choose a base branch
from

Conversation

echernyavskiy
Copy link
Contributor

Q A
Branch invoke-grumphp-using-php-binary
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets -

Fixes #1170

@veewee
Copy link
Contributor

veewee commented Apr 15, 2025

@echernyavskiy Thanks for the PR.
This doesn't seem to be working on windows. Can you take a look at the failing appveyor tasks?

@echernyavskiy
Copy link
Contributor Author

@veewee, the 8.4 failures there look like they have to do with the environment:

php --version
php : PHP Warning:  'C:\windows\SYSTEM32\VCRUNTIME140.dll' 14.22 is not compatible with this PHP build linked with 14.43 in Unknown on line 0

For other PHP versions it looks like GrumPHP's pre-commit file is not getting created for some reason. I'm not sure how to investigate this - if someone running Windows is able to look into it, that'd be great.

@veewee
Copy link
Contributor

veewee commented Apr 15, 2025

I don't own a Windows computer either. But can't merge this the way it is, since it breaks every windows installation :)
Previously, i've used appveyor to debug this kind of stuff directly from within the E2E tests and rerun. It's slow and tyring, but it gets the job done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer plugin tasks not executed using the PHP version Composer is invoked with
2 participants