Drush ProcessManager does not respect the PHP version Drush was invoked with

[echernyavskiy]

Describe the bug
When running dependent commands internally (like core:status before sql:sync), ProcessManager does not respect the PHP version Drush has originally been invoked with.

To Reproduce
Given two PHP versions installed in the system, e.g. 8.2 (the default, symlinked to /usr/bin/php) and 8.3, execute Drush sql-sync like /usr/bin/php8.3 ./vendor/bin/drush.php sql:sync ...

Expected behavior
Drush records the PHP binary it was invoked with, and re-uses it for any subsequent internal invocations.

Actual behavior
The internal invocation of core:status dependent command is made using the default version of PHP (8.2 in this example):

 /usr/bin/php8.3 /var/www/builds/my-dev-app.com/vendor/bin/drush.php --root="/var/www/builds/my-dev-app.com" --uri="https://my-dev-app.com" --yes sql:sync @app.prod @self --create-db --debug --verbose
 [preflight] Config paths: /var/www/builds/my-dev-app.com/vendor/drush/drush/drush.yml
 [preflight] Alias paths: /var/www/builds/my-dev-app.com/web/drush/sites,/var/www/builds/my-dev-app.com/drush/sites
 [preflight] Commandfile search paths: /var/www/builds/my-dev-app.com/vendor/drush/drush/src,/var/www/builds/my-dev-app.com/drush
 [info] Starting bootstrap to none [1.68 sec, 19.71 MB]
 [info] Drush bootstrap phase 0 [1.68 sec, 19.71 MB]
 [info] Try to validate bootstrap phase 0 [1.68 sec, 19.71 MB]
 [info] Executing: env PATH=/bin:/usr/bin:/usr/local/bin DRUPAL_ENVIRONMENT=development /var/www/builds/my-prod-app.com/vendor/bin/drush core:status --fields=db-name --format=json --create-db --verbose --yes -vvv --strict=0 --uri=https://my-prod-app.com [1.73 sec, 20.74 MB]
 [info] Executing: /var/www/builds/my-dev-app.com/vendor/bin/drush core:status --fields=db-name --format=json --create-db --verbose --yes -vvv --strict=0 --uri=https://my-dev-app.com [4.79 sec, 20.77 MB]

In SiteProcess.php line 214:
                                                                                                                                                                                                           
  [Symfony\Component\Process\Exception\ProcessFailedException]                                                                                                                                             
  The command "/var/www/builds/my-dev-app.com/vendor/bin/drush core:status --fields=db-name --format=json --create-db --verbose --yes -vvv --strict=0 --u  
  ri=https://my-dev-app.com" failed.                                                                                                                       
                                                                                                                                                                                                           
  Exit Code: 255(Unknown error)                                                                                                                                                                            
                                                                                                                                                                                                           
  Working directory:                                                                                                                                                                                       
                                                                                                                                                                                                           
  Output:                                                                                                                                                                                                  
  ================                                                                                                                                                                                         
                                                                                                                                                                                                           
                                                                                                                                                                                                           
  Error Output:                                                                                                                                                                                            
  ================                                                                                                                                                                                         
  Composer detected issues in your platform:                                                                                                                                                               
                                                                                                                                                                                                           
  Your Composer dependencies require a PHP version ">= 8.3.0". You are running 8.2.27.                                                                                                                     
                                                                                                                                                                                                           
  PHP Fatal error:  Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.3.0". You are running 8.2.27. in /var/www/builds/my-dev-app.com/vendor/composer/platform_check.php on line 22

Workaround
N/A

System Configuration

Q	A
Drush version?	13.5.1
Drupal version?	11.x
PHP version	8.x
OS?	Linux

Additional information
N/A

[echernyavskiy]

I recently raised a similar issue against the GrumPHP Composer package, and raised a PR there that would attempt to find a suitable PHP binary using symfony/process's PhpExecutableFinder. Wondering if people think a similar approach would work here.

[weitzman]

Dupe of #6250. Use PATH env variable to control which php gets executed.

[echernyavskiy]

@weitzman, #6250 is slightly different.
This issue is regarding "internal" Drush PHP invocations not inheriting the PHP binary Drush was originally called with.
The drush shell script calls drush.php which has the #!/usr/bin/env php shebang expression.
So even if Drush is called like this:

/usr/bin/php8.3 ./vendor/bin/drush sql:sync

the subsequent "internal" execution of core:status will happen via whatever php resolves to.
In setups where there are multiple versions of PHP installed side by side in /usr/bin (/usr/bin/php8.2 --> /usr/bin/php and /usr/bin/php8.3 in my case here) overriding the PATH variable as you recommended is not going to help.

[weitzman]

This issue is regarding "internal" Drush PHP invocations not inheriting the PHP binary Drush was originally called with.

Thats not a goal.

In setups where there are multiple versions of PHP installed side by side in /usr/bin (/usr/bin/php8.2 --> /usr/bin/php and /usr/bin/php8.3 in my case here) overriding the PATH variable as you recommended is not going to help.

Did you try it, per the docs? If you did you would see that it works. #!/usr/bin/env php means "lookup PATH and execute as configured there."

[echernyavskiy]

Did you try it, per the docs? If you did you would see that it works. #!/usr/bin/env php means "lookup PATH and execute as configured there."

I have. The problem is that php8.2, php8.3 and php (symlinked to php8.2) all live in /usr/bin, so I was prepending /usr/bin to $PATH which already contained that directory. Obviously that didn't change anything. This would have worked for a directory structure like /opt/php8.2/bin/php and /opt/php8.3/bin/php.

Thats not a goal.

I'm surprised that's the case - from my PoV it's a fair expectation that Drush uses one (implicit or explicitly specified) PHP binary for any given command run, including "internal" invocations.

Anyway, for the setup I described above I ended up patching drush.php's shebang to reference the requested PHP version i.e.

export PHP_VERSION=8.3
sed -i "1c\#\!/usr/bin/env php$(PHP_VERSION)" $(VENDOR_DIRECTORY)/bin/drush.php

[weitzman]

Could you symlink your php binaries to different directories?

[echernyavskiy]

@weitzman, yup, I considered that - also a reasonable workaround.