Skip to content

Add php 7.x to the test matrix #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Conversation

middlebrain
Copy link
Contributor

Fix behat runtime errors by using php 7.x
Travis: build with 7.x

@dbu
Copy link
Member

dbu commented Aug 28, 2018

thanks a ton for picking this up! and it seems to look like there are no issues with php 7.

i let styleci fix the styling in the master branch. can you please rebase?

the test that fails is "Execute the note-type show command" and it looks like the ordering of that node type definition changed in jackrabbit. i am confident that the order is not relevant - can you please change the order in what we expect?

@dbu
Copy link
Member

dbu commented Aug 28, 2018

re the failing test: sorry, i saw you did a separate pull request. the other PR is merged, so when you rebase this on master, it should get green \o/

@middlebrain middlebrain force-pushed the travis_build_with_7.x branch from 9463ae1 to 1f44e5b Compare August 28, 2018 19:26
@middlebrain
Copy link
Contributor Author

re the failing test: sorry, i saw you did a separate pull request.

My bad. Looking back, I should have better combined the two pull requests into one.

the other PR is merged, so when you rebase this on master, it should get green \o/

Rebase made.

@dbu
Copy link
Member

dbu commented Aug 29, 2018

great, thanks a lot!

do you want to become a contributor for this project? as we currently don't have an active maintainer, it would be great to have somebody taking care of it a bit.

@dbu dbu merged commit a1854c4 into phpcr:master Aug 29, 2018
@middlebrain middlebrain deleted the travis_build_with_7.x branch September 2, 2018 09:00
@middlebrain
Copy link
Contributor Author

As an active user of php-shell, I just wanted to fix the most annoying bugs.

There are more things that bother me. But I don't have time to dive deeper into it right now.

@dbu
Copy link
Member

dbu commented Sep 3, 2018

sure - happy to look at merge requests when you send them. just thought i'd ask if you want a more official role on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants