Refactored to add missing inheritance check #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let PHPCR handle the node type checking including inheritance.
|
i restarted the builds that failed to install because of network issues. but the one that ran notices that there is a unit test that fails now because the method on the mock node is not expected to be called. could you adjust that test please? |
Refactor tests after fixing bug in the Console\Helper\NodeHelper::nodeHasMixinType function
middlebrain
force-pushed
the
nodehasmixintype_fix
branch
from
83b42b2 to
69bad47
Compare
|
thank you! the remaining failure is not related to this pull request but is a test issue in the node type definition. (the order change is not relevant there) @middlebrain would you be motivated to add php 7 to the test matrix and see if you can fix that test error? this tool was developped and maintained by @dantleech but he currently does not have time to work on it... |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let PHPCR handle the node type checking including inheritance. See issue #190