Symfony 4 support #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dantleech can you have a look? We are planning to support symfony 4 soonish and need the PHPCR migration support. Thanks. |
chirimoya
force-pushed
the
symfony-4-support
branch
from
ecf9ac4 to
bcfc20b
Compare
|
@dantleech looks like the tests are failing because packagist is not up to date |
|
Updated on packagist, let's see |
chirimoya
force-pushed
the
symfony-4-support
branch
from
bcfc20b to
09a33e6
Compare
|
looks good, can you make a tag, so I can work on the bundle. And thanks alot for your fast response! |
|
It was actually just included as |
|
Sorry, you meant this repo. Tagged and made invited you to be a collaborator on both this and the bundle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should work after jackalope/jackalope-fs#24 is merged.